Skip to content

TUI: Add onboarding telemetry - #14620

Open
moirahuang wants to merge 1 commit into
masterfrom
moira/tui-onboarding-telemetry
Open

TUI: Add onboarding telemetry#14620
moirahuang wants to merge 1 commit into
masterfrom
moira/tui-onboarding-telemetry

Conversation

@moirahuang

@moirahuang moirahuang commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Description

  • Add low-cardinality telemetry for initial and post-logout TUI authentication journeys, including starts, device authorization readiness, browser launches, URL copies, failures, abandonment, and completion.
  • Track retry attempts and deduplicate readiness and terminal outcome events without including authentication URLs, user codes, or raw errors.
  • Report the TUI as the dedicated warp-agent-cli OAuth client while preserving warp-cli for generic SDK and fallback callers.

Plan: https://staging.warp.dev/drive/notebook/VEDTJkrbVxEnFZIwM5uC3A

Linked Issue

N/A — this is follow-up instrumentation and identity plumbing for the TUI onboarding flow.

Testing

  • ./script/format --check
  • cargo +1.92.0 check -p warp --features tui --lib
  • cargo +1.92.0 check -p warp_tui --lib
  • cargo +1.92.0 nextest run -p warp_core -p warp_server_client (101 passed)
  • cargo +1.92.0 nextest run -p warp --features tui -E "test(/tui::telemetry::tests::/) or test(/tui::tests::/)" (16 passed)
  • cargo +1.92.0 nextest run -p warp_tui -E "test(/root_view::tests::/) or test(/session::tests::/)" (17 passed; one existing leaky-process annotation)
  • cargo +1.92.0 clippy -p warp -p warp_tui -p warp_core -p warp_server_client --lib --tests --features warp/tui -- -D warnings
  • Targeted rustfmt and git diff --check
  • I have manually tested my changes locally with ./script/run

Agent Mode

  • Warp Agent Mode - This PR was created via Warp AI Agent Mode

Conversation: https://staging.warp.dev/conversation/b543d79e-e3d9-4f48-9516-50c2372eabc8

CHANGELOG-NONE

Co-Authored-By: Oz oz-agent@warp.dev

@cla-bot cla-bot Bot added the cla-signed label Aug 1, 2026
@oz-for-oss

oz-for-oss Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

@moirahuang

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@moirahuang moirahuang changed the title telemetry for onboarding TUI: Add onboarding telemetry Aug 1, 2026
@moirahuang
moirahuang requested a review from kevinyang372 August 1, 2026 06:23

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds TUI onboarding telemetry events for authentication start, browser launch, copy URL, auth failure, abandonment, and terminal completion, plus changes the TUI-reported client ID used for server requests and OAuth device authorization.

Concerns

  • The new warp-agent-cli client ID is now reported for all TUI HTTP requests and selected for the device OAuth flow, but the PR does not include or reference the required server-side registration/synchronization.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

match self {
ExecutionMode::App => "warp-app",
ExecutionMode::Tui => "warp-tui",
ExecutionMode::Tui => "warp-agent-cli",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [IMPORTANT] This changes the TUI client ID reported on every Warp HTTP request, and the file notes these IDs must stay in sync with server constants. If warp-agent-cli is not already deployed server-side (including OAuth device-client registration), TUI login/API requests can fail or be misclassified; keep reporting warp-tui until that support is live, or land/link the matching server change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant