TUI: Add onboarding telemetry - #14620
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds TUI onboarding telemetry events for authentication start, browser launch, copy URL, auth failure, abandonment, and terminal completion, plus changes the TUI-reported client ID used for server requests and OAuth device authorization.
Concerns
- The new
warp-agent-cliclient ID is now reported for all TUI HTTP requests and selected for the device OAuth flow, but the PR does not include or reference the required server-side registration/synchronization.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| match self { | ||
| ExecutionMode::App => "warp-app", | ||
| ExecutionMode::Tui => "warp-tui", | ||
| ExecutionMode::Tui => "warp-agent-cli", |
There was a problem hiding this comment.
warp-agent-cli is not already deployed server-side (including OAuth device-client registration), TUI login/API requests can fail or be misclassified; keep reporting warp-tui until that support is live, or land/link the matching server change.

Description
warp-agent-cliOAuth client while preservingwarp-clifor generic SDK and fallback callers.Plan: https://staging.warp.dev/drive/notebook/VEDTJkrbVxEnFZIwM5uC3A
Linked Issue
N/A — this is follow-up instrumentation and identity plumbing for the TUI onboarding flow.
Testing
./script/format --checkcargo +1.92.0 check -p warp --features tui --libcargo +1.92.0 check -p warp_tui --libcargo +1.92.0 nextest run -p warp_core -p warp_server_client(101 passed)cargo +1.92.0 nextest run -p warp --features tui -E "test(/tui::telemetry::tests::/) or test(/tui::tests::/)"(16 passed)cargo +1.92.0 nextest run -p warp_tui -E "test(/root_view::tests::/) or test(/session::tests::/)"(17 passed; one existing leaky-process annotation)cargo +1.92.0 clippy -p warp -p warp_tui -p warp_core -p warp_server_client --lib --tests --features warp/tui -- -D warningsrustfmtandgit diff --check./script/runAgent Mode
Conversation: https://staging.warp.dev/conversation/b543d79e-e3d9-4f48-9516-50c2372eabc8
CHANGELOG-NONE
Co-Authored-By: Oz oz-agent@warp.dev