fix: support non-SGR mouse reporting - #14567
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev> Co-Authored-By: Ben Holmes <51384119+bholmesdev@users.noreply.github.com>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR broadens alt-screen mouse forwarding so terminal apps can receive legacy normal and UTF-8 mouse reports when they enable DEC mouse tracking without SGR encoding. It also avoids panicking when an out-of-range legacy report cannot be encoded and adds regression coverage for the new encodings.
Concerns
- For this user-facing terminal interaction change, please include screenshots or a short screen recording demonstrating mouse reporting working end to end in a terminal app that uses non-SGR reporting. The description lists tests but does not include visual evidence.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Closes #2906
Summary
Validation
./script/formatcargo test -p warp_terminal escape_sequencesCARGO_BUILD_JOBS=1 cargo test -p warp test_alt_screen_select_with_sgr_mousecargo clippy -p warp_terminal --all-targets --all-features --tests -- -D warningsCARGO_BUILD_JOBS=1 cargo clippy -p warp --tests -- -D warningsNotes
CARGO_BUILD_JOBS=1 cargo clippy --workspace --all-targets --all-features --tests -- -D warnings, but it is currently blocked by existing unrelated dead-code errors in app remote-server/session-sharing code paths.