Skip to content

fix: support non-SGR mouse reporting - #14567

Open
oz-for-oss[bot] wants to merge 1 commit into
masterfrom
oz-agent/implement-issue-2906
Open

fix: support non-SGR mouse reporting#14567
oz-for-oss[bot] wants to merge 1 commit into
masterfrom
oz-agent/implement-issue-2906

Conversation

@oz-for-oss

@oz-for-oss oz-for-oss Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Closes #2906

Summary

  • Forward mouse events when a terminal app enables any DEC mouse tracking mode, instead of requiring SGR mouse mode before reporting.
  • Add normal and UTF-8 mouse report encoding fallbacks for apps/configurations that do not request SGR mouse encoding.
  • Add regression tests for SGR, legacy normal, UTF-8, and out-of-range normal mouse encoding behavior.

Validation

  • ./script/format
  • cargo test -p warp_terminal escape_sequences
  • CARGO_BUILD_JOBS=1 cargo test -p warp test_alt_screen_select_with_sgr_mouse
  • cargo clippy -p warp_terminal --all-targets --all-features --tests -- -D warnings
  • CARGO_BUILD_JOBS=1 cargo clippy -p warp --tests -- -D warnings

Notes

  • Full workspace clippy was attempted with CARGO_BUILD_JOBS=1 cargo clippy --workspace --all-targets --all-features --tests -- -D warnings, but it is currently blocked by existing unrelated dead-code errors in app remote-server/session-sharing code paths.

Co-Authored-By: Oz <oz-agent@warp.dev>

Co-Authored-By: Ben Holmes <51384119+bholmesdev@users.noreply.github.com>
@cla-bot cla-bot Bot added the cla-signed label Jul 31, 2026
@vikvang
vikvang marked this pull request as ready for review July 31, 2026 18:26
@oz-for-oss

oz-for-oss Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@vikvang

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR broadens alt-screen mouse forwarding so terminal apps can receive legacy normal and UTF-8 mouse reports when they enable DEC mouse tracking without SGR encoding. It also avoids panicking when an out-of-range legacy report cannot be encoded and adds regression coverage for the new encodings.

Concerns

  • For this user-facing terminal interaction change, please include screenshots or a short screen recording demonstrating mouse reporting working end to end in a terminal app that uses non-SGR reporting. The description lists tests but does not include visual evidence.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mouse reporting does not appear to work.

1 participant