Skip to content

Persist pin state on app close/reopen#12675

Merged
johnturcoo merged 1 commit into
masterfrom
johnturco/app-4705-persist-tabgroup-pinned-state-on-app-closure
Jun 16, 2026
Merged

Persist pin state on app close/reopen#12675
johnturcoo merged 1 commit into
masterfrom
johnturco/app-4705-persist-tabgroup-pinned-state-on-app-closure

Conversation

@johnturcoo

@johnturcoo johnturcoo commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Description

Wires pinned state through SQLite persistence layer so tab/group pin states are saved and restored on app closure/reopen.

How it works

  • Migration to add new pinned field on both the tabs and tab_groups tables
  • Updated SQLite data models for Tabs and TabGroups to include pinned state
  • capture pinned into the window snapshot on save and re-apply it on restore, both gated by FeatureFlag::PinnedTabs (view.rs)
  • Added a new sqlite test for round trip of pinned tabs and groups

Linked Issue

https://linear.app/warpdotdev/issue/APP-4705/persist-tabgroup-pinned-state-on-app-closure

Testing

  • I have manually tested my changes locally with ./script/run

Screenshots / Videos

Demo video

the demo video shows app closure and reopen. Pinned tabs and groups are restored accordingly.

@cla-bot cla-bot Bot added the cla-signed label Jun 15, 2026
@oz-for-oss

oz-for-oss Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@johnturcoo

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR wires tab and tab-group pinned state through the app snapshot and SQLite persistence layers, adds the corresponding migration/model/schema fields, restores the state behind FeatureFlag::PinnedTabs, and covers the lower-level SQLite round trip with a new test. The PR description includes visual evidence for the user-facing behavior.

Concerns

  • No blocking correctness, security, or spec-drift concerns found in the annotated diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@vkodithala vkodithala self-requested a review June 16, 2026 18:37

@vkodithala vkodithala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fuego

@johnturcoo johnturcoo merged commit 2a25193 into master Jun 16, 2026
37 checks passed
@johnturcoo johnturcoo deleted the johnturco/app-4705-persist-tabgroup-pinned-state-on-app-closure branch June 16, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants