Persist pin state on app close/reopen#12675
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR wires tab and tab-group pinned state through the app snapshot and SQLite persistence layers, adds the corresponding migration/model/schema fields, restores the state behind FeatureFlag::PinnedTabs, and covers the lower-level SQLite round trip with a new test. The PR description includes visual evidence for the user-facing behavior.
Concerns
- No blocking correctness, security, or spec-drift concerns found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Description
Wires pinned state through SQLite persistence layer so tab/group pin states are saved and restored on app closure/reopen.
How it works
pinnedstateview.rs)Linked Issue
https://linear.app/warpdotdev/issue/APP-4705/persist-tabgroup-pinned-state-on-app-closure
Testing
./script/runScreenshots / Videos
Demo video
the demo video shows app closure and reopen. Pinned tabs and groups are restored accordingly.