Add scrollable model section to custom inference modal

[dagmfactory]

Description

Makes the custom inference modal's model section independently scrollable so endpoints with many models remain visable within the modal bounds. Keeps the model header and add-model action in the scrollable section, and resets the model scroll position when the modal is prefilled.

Testing

• ./script/format --check

• cargo clippy -j 16 --workspace --exclude warp_completer --all-targets --tests -- -D warnings

• cargo clippy -j 16 -p warp_completer --all-targets --tests -- -D warnings

• cargo nextest run -j 16 -p warp -E 'test(modal_with_many_models_lays_out) | test(prefill_resets_model_scroll_position)'

• I have manually tested my changes locally with ./script/run

Screenshots / Videos

https://www.loom.com/share/50cfd484659f420a899f1520a7c8354f

Agent Mode

• Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-IMPROVEMENT: Made custom inference model lists scrollable.

Agent Artifacts

• Conversation

Co-Authored-By: Oz oz-agent@warp.dev

[oz-for-oss]

@dagmfactory

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR makes the custom inference modal's model rows independently scrollable within the fixed modal body and adds coverage for rendering many models plus resetting the model scroll state on prefill.

Concerns

• No blocking concerns found. The attached Loom link satisfies the visual-evidence requirement for this user-facing UI change.
• No approved or repository spec context was available for implementation drift checks.
• The supplemental security pass did not identify security concerns in this UI-only layout change.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

@dagmfactory

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR makes the custom inference endpoint modal height-bounded and scrollable, adds focus-based scroll positioning for form fields, and covers the behavior with layout/scroll tests. I did not find code or security issues in the annotated source changes, and the PR description includes visual evidence for the user-facing UI change.

Concerns

• The PR diff includes root-level pr_diff.txt and review.json entries with unavailable patches. These appear to be review/workflow artifacts rather than product source changes and should be removed from the branch before merge.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[danielpeng2]

A couple nits on the design:

• I think we need to give more padding between the content and the scrollbar. Is it possible to push the scrollbar further into the margin on the right?

- Can we make it so the "Cancel" and "Save" buttons aren't a part of the scrollable?