Skip to content

chore: refresh UI reference snapshot provenance #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
warp-factories wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: refresh UI reference snapshot provenance #799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07d120e
chore: refresh UI reference snapshot provenance
warp-factories[bot] Sep 25, 2026
6f1f8b7
chore: refresh UI reference snapshot provenance
warp-factories[bot] Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .agents/skills/validate_ui_refs/valid_paths.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -970,6 +970,10 @@
"name": "workspace:trigger_external_ctrl_t_file_search",
"description": "External File Search"
},
{
"name": "workspace:trigger_external_alt_c_directory_search",
"description": "External Directory Search"
},
{
"name": "input:toggle_workflows",
"description": "Workflows"
Expand Down Expand Up @@ -1660,8 +1664,8 @@
}
],
"source_repository": "warpdotdev/warp",
"source_sha": "c1a27a6a21bf001fbcb83adc30c80f05b1181dae",
"generated_at": "2026-09-20T02:07:50.098583+00:00",
"source_sha": "648d03b51121ef85302552df0b32ed7d82f15362",
"generated_at": "2026-09-30T00:04:24.840574+00:00",
"last_notified_signature": "39af57a0bff50c05feb850e0c107276c95949709bff8af11a92b9ab246905496",
"last_notified_at": "2026-09-11T15:27:54.269943+00:00"
}
}
17 changes: 14 additions & 3 deletions .agents/skills/validate_ui_refs/validate_ui_refs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1554,8 +1554,9 @@ def create_pr(

Checks for an existing open PR whose branch matches fix/ui-refs-* before
creating a new one. When one is found:
- If all current fixes and the unresolved-issue signature are already in
the PR, returns without changes.
- If all current fixes, the unresolved-issue signature, AND the local
valid_paths.json snapshot are already reflected in the PR, returns
without changes.
- Otherwise, updates the existing PR branch and description.

`fixes` may be empty: a refreshed snapshot (e.g. a `source_sha` bump) with
Expand All @@ -1576,7 +1577,17 @@ def create_pr(
if existing_pr:
new_fixes = _fixes_already_in_pr(fixes, existing_pr.get("body", ""), repo_root)
existing_signature = extract_unresolved_signature(existing_pr.get("body", ""))
if not new_fixes and existing_signature == unresolved_signature:
# A refreshed valid_paths.json (source_sha bump, new commands, etc.)
# must still land even when the unresolved-issue set is unchanged;
# otherwise provenance stays stale while open PRs sit waiting.
snapshot_changed = _snapshot_has_uncommitted_changes(
DEFAULT_VALID_PATHS_FILE, repo_root
)
if (
not new_fixes
and existing_signature == unresolved_signature
and not snapshot_changed
):
print(
f"All fixes and unresolved issues already covered by open PR "
f"#{existing_pr['number']}: {existing_pr['url']}"
Expand Down
Loading