fix: TTY detection for hook subprocesses#19
Open
wasikarn wants to merge 1 commit intowarpdotdev:mainfrom
Open
Conversation
bb7de02 to
2b585f2
Compare
Hook subprocesses spawned by Claude Code lack a controlling terminal, making /dev/tty unavailable. This caused OSC 777 notifications to fail silently in some contexts. Changes: - Walk the parent process chain to find the actual TTY device - Add termination check for PID 0/1 to prevent infinite loops - Use [[:space:]] for robust whitespace trimming (spaces + tabs) - Skip notification if TTY not found (don't fall back to broken /dev/tty) - Add tests matching production code exactly - Make tests platform-agnostic (works on macOS /dev/ttysXXX and Linux /dev/pts/N) Tested: Confirmed working with Warp v0.2026.04.08.08.36.stable_05 Note: This fix targets Unix-like systems (macOS, Linux). Windows support would require different TTY detection logic.
2b585f2 to
36e8254
Compare
Author
|
Hi @harryalbert and team, This PR is ready for review. It fixes the TTY detection issue where hook subprocesses fail to send OSC 777 notifications because /dev/tty is unavailable. Key changes:
All 43 tests pass. Tested on Warp v0.2026.04.08.08.36.stable_05. Please review when you have time. Thanks! |
yigitkonur
added a commit
to yigitkonur/claude-code-warp
that referenced
this pull request
Apr 21, 2026
Covers every hook in the Claude Code lifecycle so the Warp sidebar reflects real agent state instead of getting stuck on In progress / Blocked. State coverage - PostToolUse now fires for every tool (matcher removed). A `.blocked` marker dropped by PermissionRequest gates emission so we don't flood Warp with tool_complete on every Read/Glob/Grep — auto-approved tools skip emission entirely. Fixes stuck-Blocked without re-introducing the 200+ GB leak reported in warpdotdev#22. - New PreToolUse hook emits tool_start for live per-tool sidebar signal. - SubagentStart/Stop, PermissionDenied, PostToolUseFailure, PreCompact, PostCompact, CwdChanged, SessionEnd get dedicated scripts with a v3-only event gate (WARP_CLI_AGENT_V3_EVENTS=1). When unset, they emit v2-compatible fallbacks so the sidebar state still moves on stable Warp builds. Fresh-tab parity with Gemini/Droid - on-session-start.sh for source=startup emits nothing. Warp's process-detection registers the sidebar row without a state pill, matching Gemini CLI and Factory/Droid (neither registers a Warp hook). First OSC event fires on UserPromptSubmit. plugin_version moved onto prompt_submit so Warp's outdated-plugin banner still has a signal. - For resume/clear/compact, session_start still emits with enrichment since those genuinely change state. Payload hygiene - build-payload.sh strips empty-string --arg values so Warp doesn't see model:"" / permission_mode:"" as "still initializing". - Early-exit on empty session_id avoids stray emissions to the wrong row. - utf8_truncate helper — codepoint-aware, preserves multi-byte integrity. Reliability - PPID-walk TTY detection in warp-notify.sh (ports warpdotdev#19). Hook subprocesses often lack /dev/tty; walk the parent chain to find one. - hooks.json quotes ${CLAUDE_PLUGIN_ROOT} (ports warpdotdev#26) — Windows paths with spaces no longer break every hook. - async:true removed from Stop/StopFailure/SubagentStop. Claude Code was killing async hooks before they finished emitting in -p mode, causing tool_complete / stop emissions to silently drop. - -p headless mode: on-session-{start,end}.sh skip emission with no tty. Configurability - CLAUDE_CODE_DISABLE_TERMINAL_TITLE=1 opts out of prompt-as-title (ports warpdotdev#24 — users driving tab titles via kitty/tmux/shell hooks). - WARP_PLUGIN_DISABLE_PROJECT=1 drops the project envelope field (ports warpdotdev#23). Debugging - New scripts/warp-log.sh logs every hook input and every OSC emit to \${TMPDIR:-/tmp}/warp-claude-\${SESSION_ID}.log with sub-second timestamps. /tmp/warp-claude-latest.log is a symlink for tail -f. WARP_KEEP_LOGS=1 preserves logs past SessionEnd. Prompt lifecycle - session_title on prompt_submit labels the sidebar row with the first prompt text instead of the generic "Claude Code". - duration_ms on stop, computed from a t0 timestamp stashed on prompt_submit.
yigitkonur
added a commit
to yigitkonur/claude-code-warp
that referenced
this pull request
Apr 21, 2026
Covers:
- What the v3 fork changes relative to upstream v2 (table of fixes
with links to resolved upstream issues warpdotdev#19/warpdotdev#22/warpdotdev#23/warpdotdev#24/warpdotdev#26)
- Install / uninstall / rollback commands
- Env-var configuration: WARP_CLI_AGENT_V3_EVENTS, WARP_KEEP_LOGS,
CLAUDE_CODE_DISABLE_TERMINAL_TITLE, WARP_PLUGIN_DISABLE_PROJECT
- R5 fallback mapping (v3-only events → v2-compatible shapes)
- Debugging workflow via `tail -f /tmp/warp-claude-latest.log` with
a sample event trace from a real session
- Running the test suite
yigitkonur
added a commit
to yigitkonur/claude-code-warp
that referenced
this pull request
Apr 21, 2026
3.0.0 → 3.0.5 captures the expanded sidebar state coverage, fresh-tab zero-emission (Droid/Gemini parity), PostToolUse memory-leak gate, and five upstream-issue backports: warpdotdev#19 (TTY PPID walk), warpdotdev#22 (leak mitigation via .blocked marker), warpdotdev#23 (WARP_PLUGIN_DISABLE_PROJECT), warpdotdev#24 (CLAUDE_CODE_DISABLE_TERMINAL_TITLE), warpdotdev#26 (quote CLAUDE_PLUGIN_ROOT).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hook subprocesses spawned by Claude Code lack a controlling terminal, causing OSC 777 notifications to fail silently.
Root Cause
When Claude Code spawns hook scripts (e.g., on Stop events), the subprocess does not have a controlling terminal. Writing to
/dev/ttyfails with "Device not configured", preventing Warp notifications from being sent.Evidence:
Impact
Solution
Walk the parent process chain to find the actual TTY device that Claude Code is running on.
Changes
[[:space:]]to handle spaces and tabsKey Implementation Details
Testing
Verified Working
Test Coverage
/dev/ttysXXXon macOS and/dev/pts/Non Linux)Manual Verification
Checklist
Platform Notes
Unix-like systems (macOS, Linux): ✅ Fully supported
Windows: Not supported by this fix (requires different TTY detection logic)
cc: @harryalbert (previous contributor)