Conversation
smessie
left a comment
There was a problem hiding this comment.
This PR is already a great start, thanks! Yet, I think it still needs some refinement.
I see you created this PR branch in your own fork. However that one is outdated, so we'll have to see that we don't have merge conflicts.
Is it enough to just link to the score validation shape or do we want to write something about it?
I don’t have a strong opinion yet, but I think we could definitely start with this. However, the document would surely benefit from some additional clarifications.
Should we merge the validation function with the matcher function?
No, I think it is nice to have them separate as the matcher function calls the validation function twice.
Should we remove the argument Shape node and just use the whole shapes graph always?
I believe it is good to have the shape node explicit. But I would need some arguments to reason further over it.
Was the JavaScript pseudo code intended to be in the spec?
Not sure, but I like how it is now with the algorithm defined as text. I don't necessarily see the need for the JavaScript pseudocode to be included as well.
How do we distinguish between editor and viewer? Two types? Traversing the widget property and then check the type? Two properties editor/viewer instances of the widget on the score instance?
This is probably a good discussion point for one of our next meetings.
2d9749a to
7b2b613
Compare
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Closes #562, #609
This merge request adds the initial paragraphs of the scoring system.
Notes:
Things to discuss:
validationfunction with thematcherfunction?Shape nodeand just use the wholeshapes graphalways?