Skip to content

[UI] Scoring system#804

Open
danielbeeke wants to merge 8 commits intow3c:gh-pagesfrom
danielbeeke:feature/scoring-system
Open

[UI] Scoring system#804
danielbeeke wants to merge 8 commits intow3c:gh-pagesfrom
danielbeeke:feature/scoring-system

Conversation

@danielbeeke
Copy link
Copy Markdown
Contributor

@danielbeeke danielbeeke commented Mar 5, 2026

Closes #562, #609

This merge request adds the initial paragraphs of the scoring system.

Notes:

  • I linked to the score validation shape from a different branch
  • This merge request comes from a document that the UI task force created. We are working to tidy up this merge request.

Things to discuss:

  • Is it enough to just link to the score validation shape or do we want to write something about it?
  • Should we merge the validation function with the matcher function?
  • Should we remove the argument Shape node and just use the whole shapes graph always?
  • Was the JavaScript pseudo code intended to be in the spec?
  • How do we distinguish between editor and viewer? Two types? Traversing the widget property and then check the type? Two properties editor/viewer instances of the widget on the score instance?

@danielbeeke danielbeeke added the UI For SHACL 1.2 UI spec label Mar 5, 2026
@smessie smessie self-requested a review March 6, 2026 14:26
Copy link
Copy Markdown
Member

@smessie smessie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is already a great start, thanks! Yet, I think it still needs some refinement.

I see you created this PR branch in your own fork. However that one is outdated, so we'll have to see that we don't have merge conflicts.

Is it enough to just link to the score validation shape or do we want to write something about it?

I don’t have a strong opinion yet, but I think we could definitely start with this. However, the document would surely benefit from some additional clarifications.

Should we merge the validation function with the matcher function?

No, I think it is nice to have them separate as the matcher function calls the validation function twice.

Should we remove the argument Shape node and just use the whole shapes graph always?

I believe it is good to have the shape node explicit. But I would need some arguments to reason further over it.

Was the JavaScript pseudo code intended to be in the spec?

Not sure, but I like how it is now with the algorithm defined as text. I don't necessarily see the need for the JavaScript pseudocode to be included as well.

How do we distinguish between editor and viewer? Two types? Traversing the widget property and then check the type? Two properties editor/viewer instances of the widget on the score instance?

This is probably a good discussion point for one of our next meetings.

@danielbeeke danielbeeke force-pushed the feature/scoring-system branch from 2d9749a to 7b2b613 Compare April 10, 2026 07:24
danielbeeke and others added 4 commits April 10, 2026 09:31
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
danielbeeke and others added 3 commits April 10, 2026 09:34
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI For SHACL 1.2 UI spec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI] DASH Widget selection algorithm

4 participants