Skip to content

fix: don't abort install.sh when the OpenShell gateway health-check fails #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vyncint merged 1 commit into from
Aug 2, 2026
Merged

fix: don't abort install.sh when the OpenShell gateway health-check fails #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,15 @@ All notable changes to this project are documented here. The format follows

## [Unreleased]

### Fixed

- The `install.sh` one-line installer no longer aborts when the OpenShell installer it invokes
reports its gateway as unreachable. That health check cannot pass until the driver's `setup`
runs afterwards, so its non-zero exit is expected; the installer now tolerates it (after
confirming the `openshell` binary was installed) and continues on to install the driver and
run `setup`, which brings the gateway up. Without this, a fresh `curl … | sh` left OpenShell
and apple/container installed but the driver never set up.

## [0.2.3] - 2026-08-02

### Fixed
Expand Down
7 changes: 6 additions & 1 deletion install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,12 @@ check_openshell() {
fi
info "OpenShell is not installed (https://github.com/NVIDIA/OpenShell)"
if confirm "Install OpenShell now (runs the official installer)?"; then
curl -LsSf "$OPENSHELL_INSTALL_URL" | sh
# The official installer starts and health-checks the gateway, which
# cannot pass until this driver's `setup` runs afterwards — so a
# non-zero exit here is expected. Tolerate it and verify the binary
# landed instead; `setup` (run later) brings the gateway up.
curl -LsSf "$OPENSHELL_INSTALL_URL" | sh || true
need openshell || err "OpenShell installation failed"
else
err "OpenShell is required"
fi
Expand Down