Skip to content

fix: add role="region" to stack layout div with aria-label for WCAG 2.2 compliance #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iago1501 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add role="region" to stack layout div with aria-label for WCAG 2.2 compliance #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Fixed
- Add `role="region"` to stack layout div with aria-label to comply with WCAG 2.2 Level A (4.1.2) and ARIA 1.2 specification

## [0.1.3] - 2025-08-11
+ ### Fixed
Expand Down
2 changes: 1 addition & 1 deletion react/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const StackLayout: StorefrontFunctionComponent<Props> = ({
const handles = useCssHandles(CSS_HANDLES)
const intl = useIntl()
return (
<div className={`${handles.stackContainer} relative`} aria-label={arialabel ? arialabel : intl.formatMessage(
<div className={`${handles.stackContainer} relative`} role="region" aria-label={arialabel ? arialabel : intl.formatMessage(
{ id: 'store/stack-layout.aria-label' })}>
{React.Children.toArray(children).map((child, idx) => {

Expand Down
Loading