Skip to content

Do not extend IExpressApp from http.Server, add optional address prop#1507

Open
w666 wants to merge 1 commit into
masterfrom
fix-1503-extend-i-express-app-type
Open

Do not extend IExpressApp from http.Server, add optional address prop#1507
w666 wants to merge 1 commit into
masterfrom
fix-1503-extend-i-express-app-type

Conversation

@w666

@w666 w666 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

This is required to fix TS warnings when express.Router is passed to soap.listener

Close #1503

This is required to fix TS warnings when express.Router is passed to soap.listener

Close #1503
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 39375236-d27b-4c85-95a7-cc83d7547a2d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-1503-extend-i-express-app-type

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1.9.0 breaks compatibility with express.Router

1 participant