Fix FPU x0 writeback scoreboard#356
Open
cassuto wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes
scoreboard invalid writeback registerRTL assertion triggered by FPU compare instructions writing to integerx0, for example:It reports:
Root Cause
FPU results always asserted wb, including compare instructions whose destination is integer
x0.The decoder correctly encodes this destination as
make_reg_num(REG_TYPE_I, 0), but scoreboard does not reservex0.When the FPU later reported a writeback for
x0, RTL hit the invalid writeback assertion.Unless users write (inlined) assembly code, compilers usually do not generate
feq.s x0, ..., this is not a compiler bug.