Skip to content

Specialize VarBin PiecewiseSequence takes#8836

Draft
danking wants to merge 1 commit into
codex/piecewise-sequential-takefrom
codex/piecewise-sequence-varbin-take
Draft

Specialize VarBin PiecewiseSequence takes#8836
danking wants to merge 1 commit into
codex/piecewise-sequential-takefrom
codex/piecewise-sequence-varbin-take

Conversation

@danking

@danking danking commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • move VarBin and VarBinView PiecewiseSequence take specializations out of Use PiecewiseSequence indices for FSL take #8800 into this stacked PR
  • keep the branch based directly on codex/piecewise-sequential-take
  • preserve existing behavior: VarBin copies contiguous byte ranges, VarBinView gathers view ranges while reusing backing data buffers

Validation

  • cargo +nightly fmt --all
  • cargo check -p vortex-array

@danking danking added the changelog/chore A trivial change label Jul 17, 2026
@codspeed-hq

codspeed-hq Bot commented Jul 17, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 20.51%

❌ 2 regressed benchmarks
✅ 1796 untouched benchmarks
⏩ 52 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation copy_nullable[65536] 1 ms 1.4 ms -24.26%
Simulation copy_non_nullable[65536] 908.9 µs 1,089.5 µs -16.57%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/piecewise-sequence-varbin-take (79d9e10) with codex/piecewise-sequential-take (6ee68b3)

Open in CodSpeed

Footnotes

  1. 52 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Daniel King <dan@spiraldb.com>
@danking
danking force-pushed the codex/piecewise-sequence-varbin-take branch from 5924fe3 to 79d9e10 Compare July 17, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant