Port PiecewiseSequence run-take consumers#8802
Draft
danking wants to merge 9 commits into
Draft
Conversation
Merging this PR will regress 2 benchmarks
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
danking
force-pushed
the
codex/piecewise-sequential-take
branch
from
July 16, 2026 19:19
01e95cb to
eb83451
Compare
danking
force-pushed
the
codex/piecewise-sequential-run-take-consumers
branch
from
July 16, 2026 19:23
4272937 to
02adf44
Compare
danking
force-pushed
the
codex/piecewise-sequential-take
branch
from
July 16, 2026 20:29
eb83451 to
e79ec4b
Compare
danking
force-pushed
the
codex/piecewise-sequential-run-take-consumers
branch
2 times, most recently
from
July 16, 2026 20:36
4ff991e to
de4a71f
Compare
danking
force-pushed
the
codex/piecewise-sequential-take
branch
from
July 16, 2026 23:41
b615895 to
6dcc52a
Compare
danking
force-pushed
the
codex/piecewise-sequential-run-take-consumers
branch
from
July 16, 2026 23:52
12a04f6 to
6280163
Compare
danking
force-pushed
the
codex/piecewise-sequential-take
branch
from
July 17, 2026 00:15
6dcc52a to
a2cbdf0
Compare
danking
force-pushed
the
codex/piecewise-sequential-run-take-consumers
branch
from
July 17, 2026 00:16
6280163 to
71c3d0e
Compare
danking
force-pushed
the
codex/piecewise-sequential-take
branch
from
July 17, 2026 00:17
a2cbdf0 to
d694338
Compare
danking
force-pushed
the
codex/piecewise-sequential-run-take-consumers
branch
10 times, most recently
from
July 17, 2026 20:25
30870aa to
e777ab4
Compare
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
danking
force-pushed
the
codex/piecewise-sequential-run-take-consumers
branch
from
July 17, 2026 20:37
e777ab4 to
e4a0543
Compare
Signed-off-by: Daniel King <dan@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
List.take(PiecewiseSequence)by rebuilding list offsets and taking contiguous child element ranges whenmultipliersis a constant unsigned11instead of list-by-list rebuildValidation
cargo fmt -p vortex-arraycargo test -p vortex-array piecewise_sequencecargo test -p vortex-array piecewise_sequence_takecargo test -p vortex-array test_rebuild_flatten_large_lists_with_piecewise_indicescargo check -p vortex-arraycargo check -p vortex-array --benchesgit diff --check