Skip to content

Implement compare in vortex instead of falling back to arrow #8661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robert3005 merged 1 commit into from
Jul 8, 2026
Merged

Implement compare in vortex instead of falling back to arrow #8661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
208 changes: 178 additions & 30 deletions vortex-array/benches/compare.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,21 @@ use rand::RngExt;
use rand::SeedableRng;
use rand::distr::Uniform;
use rand::prelude::StdRng;
use vortex_array::ArrayRef;
use vortex_array::Canonical;
use vortex_array::IntoArray;
use vortex_array::VortexSessionExecute;
use vortex_array::arrays::BoolArray;
use vortex_array::arrays::ConstantArray;
use vortex_array::arrays::DecimalArray;
use vortex_array::arrays::PrimitiveArray;
use vortex_array::arrays::StructArray;
use vortex_array::arrays::VarBinViewArray;
use vortex_array::builtins::ArrayBuiltins;
use vortex_array::dtype::DecimalDType;
use vortex_array::scalar::Scalar;
use vortex_array::scalar_fn::fns::operators::Operator;
use vortex_array::validity::Validity;
use vortex_buffer::Buffer;

fn main() {
Expand All @@ -22,51 +31,190 @@ fn main() {

const ARRAY_SIZE: usize = 65_536;

#[divan::bench]
fn compare_bool(bencher: Bencher) {
let mut rng = StdRng::seed_from_u64(0);
let range = Uniform::new(0u8, 1).unwrap();

let arr1 = BoolArray::from_iter((0..ARRAY_SIZE).map(|_| rng.sample(range) == 0)).into_array();
let arr2 = BoolArray::from_iter((0..ARRAY_SIZE).map(|_| rng.sample(range) == 0)).into_array();
fn bench_compare(bencher: Bencher, lhs: ArrayRef, rhs: ArrayRef, op: Operator) {
let session = vortex_array::array_session();

bencher
.with_inputs(|| (&arr1, &arr2, session.create_execution_ctx()))
.with_inputs(|| (&lhs, &rhs, session.create_execution_ctx()))
.bench_refs(|input| {
input
.0
.clone()
.binary(input.1.clone(), Operator::Gte)
.binary(input.1.clone(), op)
.unwrap()
.execute::<Canonical>(&mut input.2)
});
}

#[divan::bench]
fn compare_int(bencher: Bencher) {
let mut rng = StdRng::seed_from_u64(0);
let range = Uniform::new(0i64, 100_000_000).unwrap();
fn bool_array(rng: &mut StdRng) -> ArrayRef {
BoolArray::from_iter((0..ARRAY_SIZE).map(|_| rng.random_bool(0.5))).into_array()
}

fn bool_array_nullable(rng: &mut StdRng) -> ArrayRef {
BoolArray::new(
(0..ARRAY_SIZE).map(|_| rng.random_bool(0.5)).collect(),
Validity::from_iter((0..ARRAY_SIZE).map(|_| rng.random_bool(0.9))),
)
.into_array()
}

let arr1 = (0..ARRAY_SIZE)
fn int_array(rng: &mut StdRng) -> ArrayRef {
let range = Uniform::new(0i64, 100_000_000).unwrap();
(0..ARRAY_SIZE)
.map(|_| rng.sample(range))
.collect::<Buffer<_>>()
.into_array();
.into_array()
}

let arr2 = (0..ARRAY_SIZE)
.map(|_| rng.sample(range))
fn int_array_nullable(rng: &mut StdRng) -> ArrayRef {
let range = Uniform::new(0i64, 100_000_000).unwrap();
PrimitiveArray::new(
(0..ARRAY_SIZE)
.map(|_| rng.sample(range))
.collect::<Buffer<_>>(),
Validity::from_iter((0..ARRAY_SIZE).map(|_| rng.random_bool(0.9))),
)
.into_array()
}

fn float_array(rng: &mut StdRng) -> ArrayRef {
(0..ARRAY_SIZE)
.map(|_| rng.random_range(0.0f64..1.0))
.collect::<Buffer<_>>()
.into_array();
let session = vortex_array::array_session();
.into_array()
}

bencher
.with_inputs(|| (&arr1, &arr2, session.create_execution_ctx()))
.bench_refs(|input| {
input
.0
.clone()
.binary(input.1.clone(), Operator::Gte)
.unwrap()
.execute::<Canonical>(&mut input.2)
});
fn string_array(rng: &mut StdRng) -> ArrayRef {
VarBinViewArray::from_iter_str((0..ARRAY_SIZE).map(|_| {
let len = rng.random_range(1usize..24);
(0..len)
.map(|_| char::from(rng.random_range(b'a'..=b'z')))
.collect::<String>()
}))
.into_array()
}

fn decimal_array(rng: &mut StdRng) -> ArrayRef {
DecimalArray::from_iter::<i128, _>(
(0..ARRAY_SIZE).map(|_| rng.random_range(0i128..100_000_000)),
DecimalDType::new(38, 2),
)
.into_array()
}

#[divan::bench]
fn compare_bool(bencher: Bencher) {
let mut rng = StdRng::seed_from_u64(0);
let arr1 = bool_array(&mut rng);
let arr2 = bool_array(&mut rng);
bench_compare(bencher, arr1, arr2, Operator::Gte);
}

#[divan::bench]
fn compare_bool_nullable(bencher: Bencher) {
let mut rng = StdRng::seed_from_u64(0);
let arr1 = bool_array_nullable(&mut rng);
let arr2 = bool_array_nullable(&mut rng);
bench_compare(bencher, arr1, arr2, Operator::Gte);
}

#[divan::bench]
fn compare_bool_constant(bencher: Bencher) {
let mut rng = StdRng::seed_from_u64(0);
let arr = bool_array(&mut rng);
let constant = ConstantArray::new(true, ARRAY_SIZE).into_array();
bench_compare(bencher, arr, constant, Operator::Eq);
}

#[divan::bench]
fn compare_int(bencher: Bencher) {
let mut rng = StdRng::seed_from_u64(0);
let arr1 = int_array(&mut rng);
let arr2 = int_array(&mut rng);
bench_compare(bencher, arr1, arr2, Operator::Gte);
}

#[divan::bench]
fn compare_int_nullable(bencher: Bencher) {
let mut rng = StdRng::seed_from_u64(0);
let arr1 = int_array_nullable(&mut rng);
let arr2 = int_array_nullable(&mut rng);
bench_compare(bencher, arr1, arr2, Operator::Gte);
}

#[divan::bench]
fn compare_int_constant(bencher: Bencher) {
let mut rng = StdRng::seed_from_u64(0);
let arr = int_array(&mut rng);
let constant = ConstantArray::new(50_000_000i64, ARRAY_SIZE).into_array();
bench_compare(bencher, arr, constant, Operator::Gte);
}

#[divan::bench]
fn compare_int_eq(bencher: Bencher) {
let mut rng = StdRng::seed_from_u64(0);
let arr1 = int_array(&mut rng);
let arr2 = int_array(&mut rng);
bench_compare(bencher, arr1, arr2, Operator::Eq);
}

#[divan::bench]
fn compare_float(bencher: Bencher) {
let mut rng = StdRng::seed_from_u64(0);
let arr1 = float_array(&mut rng);
let arr2 = float_array(&mut rng);
bench_compare(bencher, arr1, arr2, Operator::Gte);
}

#[divan::bench]
fn compare_decimal(bencher: Bencher) {
let mut rng = StdRng::seed_from_u64(0);
let arr1 = decimal_array(&mut rng);
let arr2 = decimal_array(&mut rng);
bench_compare(bencher, arr1, arr2, Operator::Gte);
}

#[divan::bench]
fn compare_string_eq(bencher: Bencher) {
let mut rng = StdRng::seed_from_u64(0);
let arr1 = string_array(&mut rng);
let arr2 = string_array(&mut rng);
bench_compare(bencher, arr1, arr2, Operator::Eq);
}

#[divan::bench]
fn compare_string_lt(bencher: Bencher) {
let mut rng = StdRng::seed_from_u64(0);
let arr1 = string_array(&mut rng);
let arr2 = string_array(&mut rng);
bench_compare(bencher, arr1, arr2, Operator::Lt);
}

#[divan::bench]
fn compare_string_constant(bencher: Bencher) {
let mut rng = StdRng::seed_from_u64(0);
let arr = string_array(&mut rng);
let constant = ConstantArray::new(Scalar::from("mmmmmmmmmmmm"), ARRAY_SIZE).into_array();
bench_compare(bencher, arr, constant, Operator::Lt);
}

fn struct_array(rng: &mut StdRng) -> ArrayRef {
StructArray::from_fields(&[("a", int_array(rng)), ("b", int_array(rng))])
.unwrap()
.into_array()
}

#[divan::bench]
fn compare_struct_lt(bencher: Bencher) {
let mut rng = StdRng::seed_from_u64(0);
let arr1 = struct_array(&mut rng);
let arr2 = struct_array(&mut rng);
bench_compare(bencher, arr1, arr2, Operator::Lt);
}

#[divan::bench]
fn compare_struct_eq(bencher: Bencher) {
let mut rng = StdRng::seed_from_u64(0);
let arr1 = struct_array(&mut rng);
let arr2 = struct_array(&mut rng);
bench_compare(bencher, arr1, arr2, Operator::Eq);
}
6 changes: 6 additions & 0 deletions vortex-array/src/arrays/extension/compute/compare.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ impl CompareKernel for Extension {
operator: CompareOperator,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Option<ArrayRef>> {
// Storage values are only comparable when both sides share the same extension dtype
// (e.g. timestamps in different units must not compare their raw storage).
if !lhs.dtype().eq_ignore_nullability(rhs.dtype()) {
return Ok(None);
}

// If the RHS is a constant, we can extract the storage scalar.
if let Some(const_ext) = rhs.as_constant() {
let storage_scalar = const_ext.as_extension().to_storage_scalar();
Expand Down
Loading
Loading