Skip to content

Initialize LazyBitBufferBuilder from Mask if available, when appending masks pass them by reference#8221

Merged
AdamGS merged 2 commits into
developfrom
rk/validitybyref
Jun 4, 2026
Merged

Initialize LazyBitBufferBuilder from Mask if available, when appending masks pass them by reference#8221
AdamGS merged 2 commits into
developfrom
rk/validitybyref

Conversation

@robert3005
Copy link
Copy Markdown
Contributor

At the same time the set methods can initialize the validity buffer from the
passed mask instead of allocating and copying

…pied

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 changed the title Pass Mask by reference to to builders append methods as it must be copied Initialize LazyBitBufferBuilder from Mask if available, when appending masks pass them by reference Jun 2, 2026
@robert3005 robert3005 added the changelog/break A breaking API change label Jun 2, 2026
Signed-off-by: Robert Kruszewski <github@robertk.io>
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 2, 2026

Merging this PR will improve performance by 23.44%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 4 improved benchmarks
✅ 1271 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation baseline_eq[4, 65536] 237.9 µs 185.1 µs +28.53%
Simulation baseline_lt[16, 65536] 275.5 µs 217.6 µs +26.61%
Simulation baseline_lt[4, 65536] 253.2 µs 200.9 µs +26%
Simulation baseline_eq[16, 65536] 260.5 µs 230 µs +13.25%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/validitybyref (8d85f87) with develop (84a4a3f)

Open in CodSpeed

@robert3005 robert3005 requested review from AdamGS and onursatici June 4, 2026 07:36
@AdamGS AdamGS merged commit 030dcb8 into develop Jun 4, 2026
79 of 85 checks passed
@AdamGS AdamGS deleted the rk/validitybyref branch June 4, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants