Skip to content

Introduce a new JSON extension type in vortex-json#8215

Open
AdamGS wants to merge 4 commits into
developfrom
adamg/vortex-json
Open

Introduce a new JSON extension type in vortex-json#8215
AdamGS wants to merge 4 commits into
developfrom
adamg/vortex-json

Conversation

@AdamGS
Copy link
Copy Markdown
Contributor

@AdamGS AdamGS commented Jun 2, 2026

Summary

This PR introduces a new JSON extension type, with more work building on top of it planned in the future. This is a building block towards the variant-based compressor and similar work.

API Changes

Includes a minor change, unifiying the two EmptyMetadata types we currently have into one.

AdamGS added 2 commits June 2, 2026 14:28
.
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS changed the title Introduce a new JSO Introduce a new JSON extension type Jun 2, 2026
@AdamGS AdamGS changed the title Introduce a new JSON extension type Introduce a new JSON extension type in vortex-json Jun 2, 2026
@AdamGS AdamGS requested review from connortsui20 and gatesn June 2, 2026 13:40
@AdamGS AdamGS added the changelog/feature A new feature label Jun 2, 2026
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 2, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 1272 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_canonical_into[(1000, 10)] 161.3 µs 197.7 µs -18.38%
Simulation bitwise_not_vortex_buffer_mut[128] 246.1 ns 275.3 ns -10.6%
Simulation chunked_varbinview_canonical_into[(100, 100)] 308.3 µs 273.3 µs +12.8%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/vortex-json (bd02756) with develop (1552135)

Open in CodSpeed

@AdamGS AdamGS requested a review from robert3005 June 3, 2026 14:07
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant