Rename percision to accuracy#8214
Open
AdamGS wants to merge 1 commit into
Open
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Merging this PR will improve performance by 13.42%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | take_map[(0.1, 1.0)] |
1.9 ms | 1.7 ms | +16.15% |
| ⚡ | Simulation | take_map[(0.1, 0.5)] |
1,092.6 µs | 986.5 µs | +10.75% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing adamg/rename-percision-to-accuracy (8e186ed) with develop (5aa3f3d)
robert3005
approved these changes
Jun 2, 2026
joseph-isaacs
requested changes
Jun 2, 2026
Contributor
joseph-isaacs
left a comment
There was a problem hiding this comment.
accuracy is the wrong word
Contributor
|
exactness? |
Contributor
Author
|
how about splitting it into two functions on the same trait? the enum seems confusing |
Contributor
|
should we just call this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR renames the
Precisionenum that we use to do array hashing and equality checks toAccuracy, as we already have aPrecisionenum we use for stats, that is also part of the binary format.API Changes
Just the renamed enum, which should be relatively minor.
Testing
N/A