break: remove deprecated methods and plumb ExecutionCtx#7512
Open
joseph-isaacs wants to merge 5 commits intodevelopfrom
Open
break: remove deprecated methods and plumb ExecutionCtx#7512joseph-isaacs wants to merge 5 commits intodevelopfrom
joseph-isaacs wants to merge 5 commits intodevelopfrom
Conversation
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
joseph-isaacs
changed the title
Merging this PR will degrade performance by 54.17%
Performance Changes
Comparing 
Footnotes
|
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (1)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 1.000x ➖ datafusion / vortex-file-compressed (1.000x ➖, 0↑ 0↓)
|
Contributor
File Sizes: PolarSignals ProfilingNo file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.269x ❌, 0↑ 22↓)
datafusion / vortex-compact (1.229x ❌, 0↑ 22↓)
datafusion / parquet (1.023x ➖, 1↑ 5↓)
datafusion / arrow (0.937x ➖, 4↑ 0↓)
duckdb / vortex-file-compressed (1.018x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.975x ➖, 2↑ 0↓)
duckdb / parquet (1.096x ➖, 0↑ 8↓)
duckdb / duckdb (0.970x ➖, 1↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-H SF=1 on NVMENo file size changes detected. |
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.977x ➖, 1↑ 0↓)
datafusion / vortex-compact (0.968x ➖, 1↑ 0↓)
datafusion / parquet (0.955x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.946x ➖, 3↑ 0↓)
duckdb / vortex-compact (0.951x ➖, 2↑ 0↓)
duckdb / parquet (0.946x ➖, 1↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: FineWeb NVMeNo file size changes detected. |
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.985x ➖, 1↑ 0↓)
datafusion / vortex-compact (0.991x ➖, 0↑ 0↓)
datafusion / parquet (0.995x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed (0.991x ➖, 1↑ 0↓)
duckdb / vortex-compact (0.989x ➖, 1↑ 0↓)
duckdb / parquet (0.989x ➖, 0↑ 0↓)
duckdb / duckdb (0.994x ➖, 1↑ 2↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-DS SF=1 on NVMENo file size changes detected. |
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.112x ➖, 0↑ 2↓)
datafusion / vortex-compact (0.897x ➖, 1↑ 0↓)
datafusion / parquet (0.988x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.038x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.025x ➖, 0↑ 1↓)
duckdb / parquet (0.996x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: Random AccessVortex (geomean): 0.831x ✅ unknown / unknown (0.935x ➖, 11↑ 0↓)
|
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) duckdb / vortex-file-compressed (1.014x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.994x ➖, 0↑ 0↓)
duckdb / parquet (1.011x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: Statistical and Population GeneticsNo file size changes detected. |
Contributor
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.961x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.970x ➖, 0↑ 0↓)
datafusion / parquet (0.961x ➖, 1↑ 0↓)
datafusion / arrow (0.938x ➖, 3↑ 0↓)
duckdb / vortex-file-compressed (0.963x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.970x ➖, 0↑ 0↓)
duckdb / parquet (0.979x ➖, 1↑ 0↓)
duckdb / duckdb (0.977x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-H SF=10 on NVMENo file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.882x ➖, 2↑ 0↓)
datafusion / vortex-compact (0.907x ➖, 0↑ 0↓)
datafusion / parquet (0.937x ➖, 2↑ 0↓)
duckdb / vortex-file-compressed (0.956x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.984x ➖, 0↑ 0↓)
duckdb / parquet (1.005x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
File Sizes: Clickbench on NVMEFile Size Changes (1 files changed, -0.0% overall, 0↑ 1↓)
Totals:
|
Contributor
Benchmarks: CompressionVortex (geomean): 1.094x ➖ unknown / unknown (1.051x ➖, 18↑ 24↓)
|
Contributor
Benchmarks: TPC-H SF=10 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.025x ➖, 0↑ 1↓)
datafusion / vortex-compact (0.900x ➖, 1↑ 0↓)
datafusion / parquet (0.970x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed (0.929x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.951x ➖, 0↑ 0↓)
duckdb / parquet (0.985x ➖, 0↑ 0↓)
Full attributed analysis
|
joseph-isaacs
changed the title
joseph-isaacs
changed the title
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
…e public-api locks - Add missing `&mut ctx` arg to BitPacked::encode calls in benches and CUDA code - Add missing VortexSessionExecute import in compat-gen and CUDA test modules - Fix CudaExecutionCtx/ExecutionCtx type mismatches using .execution_ctx() - Fix clippy: redundant clone, too-many-arguments, auto-deref - Regenerate public-api.lock files - Run cargo fmt Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Fix BitPackedData::encode doctest in unpack_iter.rs - Fix RunEnd::new doctest in array.rs - Fix 3 new CUDA bitpacked tests from develop that were missing ctx arg Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
joseph-isaacs
force-pushed
the
ji/remove-dep-encodings-2
branch
from
3c82c3e to
eece5fe
Compare
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
|
@claude review this in detail. Assume things are incorrect. |
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
1 similar comment
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove deprecated compute methods that lack an
ExecutionCtxparameter (e.g.,to_canonical) and plumbExecutionCtxthrough remaining callsites.Key changes:
&mut ExecutionCtxparameter toBitPacked::encode,RunEnd::new, and other encoding methodsAPI Changes
Breaking change: encoding methods like
BitPacked::encodenow require an&mut ExecutionCtxparameter.