Optimize inner product, update boilerplate, remove bad benchmarks#7428
Merged
connortsui20 merged 1 commit intodevelopfrom Apr 14, 2026
Merged
Optimize inner product, update boilerplate, remove bad benchmarks#7428connortsui20 merged 1 commit intodevelopfrom
connortsui20 merged 1 commit intodevelopfrom
Conversation
connortsui20
force-pushed
the
ct/tq-optimization
branch
from
a790319 to
a48ebd0
Compare
connortsui20
changed the title
connortsui20
force-pushed
the
ct/tq-optimization
branch
from
254989b to
d4674b4
Compare
joseph-isaacs
approved these changes
Apr 14, 2026
connortsui20
force-pushed
the
ct/tq-optimization
branch
from
4d0cff3 to
8204eb1
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/tq-optimization
branch
from
8204eb1 to
002b852
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracking issue: #7297
Optimizes inner product with manual partial sum decomposition (because the compiler can't optimize this because float addition is not associative).
Also removes the old benchmarks as they no longer really time the correct thing anymore. The real benchmarks will be finished here: #7399. This change also adds the
vortex-tensor/src/vector_search.rsfile to support that soon.Testing
N/A