Skip to content

add unstable encodings and patches to benchmarks #7426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joseph-isaacs merged 4 commits into from
Apr 14, 2026
Merged

add unstable encodings and patches to benchmarks #7426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f5dadd
fix
joseph-isaacs Apr 14, 2026
7d50166
fix
joseph-isaacs Apr 14, 2026
e91b4d2
Merge branch 'develop' into ji/add-more-exp
joseph-isaacs Apr 14, 2026
799cae2
Merge branch 'develop' into ji/add-more-exp
joseph-isaacs Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/scripts/run-sql-bench.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@

set -Eeu -o pipefail

export VORTEX_EXPERIMENTAL_PATCHED_ARRAY=1
export FLAT_LAYOUT_INLINE_ARRAY_NODE=1

subcommand="$1"
targets="$2"
shift 2
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/bench-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
env:
RUSTFLAGS: "-C target-cpu=native"
run: |
cargo build --package ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }}
cargo build --package ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }} --features unstable_encodings

- name: Setup Polar Signals
if: github.event.pull_request.head.repo.fork == false
Expand All @@ -76,6 +76,8 @@ jobs:
shell: bash
env:
RUST_BACKTRACE: full
VORTEX_EXPERIMENTAL_PATCHED_ARRAY: "1"
FLAT_LAYOUT_INLINE_ARRAY_NODE: "1"
run: |
bash scripts/bench-taskset.sh target/release_debug/${{ matrix.benchmark.id }} -d gh-json -o results.json

Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
env:
RUSTFLAGS: "-C target-cpu=native"
run: |
cargo build --bin ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }}
cargo build --bin ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }} --features unstable_encodings

- name: Setup Polar Signals
uses: polarsignals/gh-actions-ps-profiling@v0.8.1
Expand All @@ -89,6 +89,8 @@ jobs:
shell: bash
env:
RUST_BACKTRACE: full
VORTEX_EXPERIMENTAL_PATCHED_ARRAY: "1"
FLAT_LAYOUT_INLINE_ARRAY_NODE: "1"
run: |
bash scripts/bench-taskset.sh target/release_debug/${{ matrix.benchmark.id }} --formats ${{ matrix.benchmark.formats }} -d gh-json -o results.json

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sql-benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ jobs:
if [ "${{ matrix.build_lance }}" = "true" ]; then
packages="$packages --bin lance-bench"
fi
cargo build $packages --profile release_debug
cargo build $packages --profile release_debug --features unstable_encodings

- name: Generate data
shell: bash
Expand Down
1 change: 1 addition & 0 deletions benchmarks/compress-bench/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ vortex-bench = { workspace = true }

[features]
lance = ["dep:lance-bench"]
unstable_encodings = ["vortex/unstable_encodings"]

[lints]
workspace = true
1 change: 1 addition & 0 deletions benchmarks/datafusion-bench/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ custom-labels = { workspace = true }

[features]
cuda = ["dep:vortex-cuda"]
unstable_encodings = ["vortex/unstable_encodings"]

[lints]
workspace = true
1 change: 1 addition & 0 deletions benchmarks/duckdb-bench/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ vortex-duckdb = { workspace = true }

[features]
cuda = ["dep:vortex-cuda"]
unstable_encodings = ["vortex/unstable_encodings"]

[lints]
workspace = true
3 changes: 3 additions & 0 deletions benchmarks/lance-bench/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,8 @@ tokio = { workspace = true, features = ["full"] }
tracing = { workspace = true }
vortex-bench = { workspace = true }

[features]
unstable_encodings = ["vortex-bench/unstable_encodings"]

[lints]
workspace = true
1 change: 1 addition & 0 deletions benchmarks/random-access-bench/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ vortex-bench = { workspace = true }

[features]
lance = ["dep:lance-bench"]
unstable_encodings = ["vortex-bench/unstable_encodings"]

[lints]
workspace = true
3 changes: 3 additions & 0 deletions vortex-bench/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,6 @@ vortex = { workspace = true, features = [
"tokio",
"zstd",
] }

[features]
unstable_encodings = ["vortex/unstable_encodings"]
Loading