Repository navigation
chore: upgrade Vite+ to 1.6 and apply vp migrate - #781
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://chore-vp-upgrade-void-cloud.voidzero-docs.workers.dev (commit 8267a01)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
cpojer
pushed a commit
that referenced
this pull request
Nov 11, 2026
…orts (#782) ## Summary `vp lint` and `vp check` did not report imports from `vitest`. Vite+ reports them with the `vite-plus/prefer-vite-plus-imports` rule from its `vite-plus/oxlint-plugin` JS plugin. This rule runs only when the `lint` block lists both the plugin and the rule. `vp create` and `vp migrate` add them only when a project has no `lint` block yet. Void had a `lint` block before Vite+ added the rule, so the rule never ran here. ## Changes - `vite.config.ts`: add the `vite-plus/oxlint-plugin` JS plugin and set `vite-plus/prefer-vite-plus-imports` to `error`. - Seven platform test files in `platform/packages/{api,dashboard}/test`: import from `vite-plus/test` instead of `vitest`. ## Behavior - A new import from `vitest` or `@vitest/browser*` now fails `vp lint`, `vp check`, and the staged-files hook. - `vp check --fix` rewrites the import to the matching `vite-plus/test*` path. - `declare module 'vitest'` augmentations stay valid. The rule does not report them. - Lint time on the full repository stays about the same: 1.2–1.7 s before, about 1.5 s after. ## Relation to #781 #781 makes the same seven import changes as part of the Vite+ 1.6 upgrade. The edits are identical, so the two PRs do not conflict. This PR does not remove the `vitest` devDependency from `platform/package.json` or the catalog entry. #781 removes them together with the upgrade. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
I had an error running `vp run build` on a fresh checkout: ``` $ vp run build:all error: Failed to plan tasks from `vp run build` in task build:all * Failed to plan tasks from `vp run --filter './packages/**' --parallel build` in task build * Invalid vite task command: vp with args ["pack"] under cwd /Users/skoss/code/voidzero/voidzero-dev/void/packages/create-void * Failed to resolve pack command: GenericFailure, Expected @voidzero-dev/vite-plus-core@1.6.0, but found @voidzero-dev/vite-plus-core@1.5.0 at /Users/skoss/code/voidzero/voidzero-dev/void/node_modules/.pnpm/@voidzero-dev+vite-plus-core@1.5.0_@types+node@26.6.6_esbuild@0.28.2_jiti@2.7.0_sass-em_1594fd50e3acc8a93202304e36c63c1d/node_modules/@voidzero-dev/vite-plus-core/package.json. Run `vp migrate` to align the Vite alias, then run `vp install`. ``` The problem was that I had a newer Vite+ version (tested with 1.5.1 and 1.6.0). So I applied `vp migrate`.
kossnocorp
force-pushed
the
chore/vp-upgrade
branch
from
November 11, 2026 08:45
adf1fa2 to
8267a01
Compare
kossnocorp
marked this pull request as ready for review
November 11, 2026 08:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had an error running
vp run buildon a fresh checkout:The problem was that I had a newer Vite+ version (tested with 1.5.1 and 1.6.0).
So I applied
vp migrate.