Skip to content

fix(cli): expose Vitest 5 options in test help - #2809

Open
Marve10s wants to merge 2 commits into
voidzero-dev:mainfrom
Marve10s:fix/vitest-5-test-help
Open

Marve10s wants to merge 2 commits into
voidzero-dev:mainfrom
Marve10s:fix/vitest-5-test-help

Conversation

@Marve10s

Copy link
Copy Markdown

vp test --help omits five top-level options accepted by the bundled Vitest 5, so users cannot discover them through the CLI. The static help list also still refers to experimental.fsModuleCache after that option moved to the top level.

Add --repeats, --injectCjsGlobals, --fsModuleCache, --fsModuleCachePath, and --sharedViteServer with their upstream descriptions and defaults, and correct the --clearCache description. Update the recorded output for both help aliases. The change is limited to help text and its snapshots.

Fixes #2804.

@fengmk2
fengmk2 requested a review from liangmiQwQ September 24, 2026 11:03

@liangmiQwQ liangmiQwQ left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fengmk2

fengmk2 commented Sep 24, 2026

Copy link
Copy Markdown
Member

@liangmiQwQ

liangmiQwQ commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

@liangmiQwQ I'm curious why this skill at https://github.com/voidzero-dev/vite-plus/blob/main/.claude/skills/sync-upstream-cli-help/SKILL.md didn't take effect.

@fengmk2 I think the reason is that we manually update Vitest major in #2551, which won't trigger the skill.

Comment thread packages/cli/src/help.ts Outdated
Comment thread packages/cli/src/help.ts Outdated
Comment thread packages/cli/src/help.ts Outdated
Comment thread packages/cli/src/help.ts Outdated
Comment thread packages/cli/src/help.ts Outdated
Comment thread packages/cli/src/help.ts Outdated
Comment thread packages/cli/src/help.ts Outdated

@liangmiQwQ liangmiQwQ left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vp test --help omits Vitest 5 CLI options (--repeats, --fsModuleCache, --sharedViteServer, ...)

3 participants