Skip to content

fix(output): print notes to stderr #2265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wan9chi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(output): print notes to stderr #2265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions crates/vite_shared/src/output.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,14 @@ pub fn error(msg: &str) {
eprintln!("{} {msg}", "error:".red().bold());
}

/// Print a note message to stdout (supplementary info).
#[expect(clippy::print_stdout, clippy::print_stderr, clippy::disallowed_macros)]
/// Print a note message to stderr (supplementary info).
///
/// A note explains the situation around a command rather than being part of
/// its result, so it belongs on the diagnostic stream: piping stdout to a file
/// or a parser keeps the command's own output intact.
#[expect(clippy::print_stderr, clippy::disallowed_macros)]
pub fn note(msg: &str) {
if user_output_to_stderr() {
eprintln!("{} {msg}", "note:".dimmed().bold());
} else {
println!("{} {msg}", "note:".dimmed().bold());
}
eprintln!("{} {msg}", "note:".dimmed().bold());
}

/// Print a success line with checkmark to stdout.
Expand Down
Loading