fix(global-cli): correct stale delegation comments and run/exec help hint#2236
Open
shulaoda wants to merge 1 commit into
Open
Conversation
👷 Deploy Preview for viteplus-preview processing.
|
✅ Deploy Preview for viteplus-preview canceled.
|
1 similar comment
✅ Deploy Preview for viteplus-preview canceled.
|
Contributor
Native binary sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
vp (Linux x64) |
Binary | 10.31 MiB | 10.31 MiB | 0 B (0.00%) |
vp (Linux x64) |
gzip -9 | 4.42 MiB | 4.42 MiB | +2 B (+0.00%) |
| NAPI (Linux x64) | Binary | 33.07 MiB | 33.07 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | gzip -9 | 12.72 MiB | 12.72 MiB | -1 B (-0.00%) |
vp (macOS ARM64) |
Binary | 7.64 MiB | 7.64 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 3.84 MiB | 3.84 MiB | -39 B (-0.00%) |
| NAPI (macOS ARM64) | Binary | 40.50 MiB | 40.50 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 16.97 MiB | 16.97 MiB | -85 B (-0.00%) |
vp (Windows x64) |
Binary | 8.35 MiB | 8.35 MiB | 0 B (0.00%) |
vp (Windows x64) |
gzip -9 | 3.64 MiB | 3.64 MiB | +1 B (+0.00%) |
| NAPI (Windows x64) | Binary | 27.51 MiB | 27.51 MiB | 0 B (0.00%) |
| NAPI (Windows x64) | gzip -9 | 10.70 MiB | 10.70 MiB | +4 B (+0.00%) |
| Trampoline (Windows x64) | Binary | 203.00 KiB | 203.00 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 97.91 KiB | 97.91 KiB | 0 B (0.00%) |
| Installer (Windows x64) | Binary | 4.44 MiB | 4.44 MiB | 0 B (0.00%) |
| Installer (Windows x64) | gzip -9 | 2.08 MiB | 2.08 MiB | 0 B (0.00%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two outdated bits in the global CLI, no behaviour change beyond the help string:
1. Stale "stubs" comments (
cli.rs)The Category C (local-CLI delegation) commands were commented as
(stubs for now)/(stubs), but every arm fully forwards to the local vite-plus CLI viacommands::delegate::execute— they are real, working delegations, not placeholders. Both comments now read(forwarded to the local vite-plus CLI).2. Misleading run/exec help hint (
help.rs)The
runandexecdelegated help docs ended their options with:But
Run/Execare declared#[command(disable_help_flag = true)], and their help is printed by a single static doc —-hand--helpproduce identical output, so the "(see more with '--help')" hint is inaccurate copied clap boilerplate. The other nine delegated docs already use plainPrint help; run/exec now match.