fix(migrate): reject workspace member targets#2229
Draft
leslieeilsel wants to merge 1 commit into
Draft
Conversation
✅ Deploy Preview for viteplus-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vp migratewhen its target is inside a detected workspace but is not the workspace rootWhy
parseArgs()preserves a nested target such as a workspace member, butdetectWorkspace()promotes the migration root to the enclosing workspace. The rest of migration then operates on that root, so runningvp migrate .from a member can unexpectedly rewrite the outer workspace.Migration updates shared package-manager configuration, catalogs, and lockfiles, so treating a workspace member as a standalone migration target is not safe. This change fails early instead.
Fixes #2124.
Validation
node packages/cli/bin/vp check packages/cli/src/migration/bin.tspnpm -F vite-plus exec vitest run src/migration(365 tests)VP_SNAP_SKIP_FLAVORS=local cargo test -p vite_cli_snapshots -- migration_workspace_member_targetmigration_subpathsnapshotmigration_monorepo_pnpmsnapshotcargo fmt --all -- --check