Skip to content

fix(create): honor explicit package manager outside monorepos#2226

Open
jong-kyung wants to merge 4 commits into
voidzero-dev:mainfrom
jong-kyung:fix/create-package-manager-precedence
Open

fix(create): honor explicit package manager outside monorepos#2226
jong-kyung wants to merge 4 commits into
voidzero-dev:mainfrom
jong-kyung:fix/create-package-manager-precedence

Conversation

@jong-kyung

Copy link
Copy Markdown
Collaborator

Summary

Preserve the existing package manager inside monorepos while allowing an explicit vp create --package-manager
option to override package manager signals inherited from non-monorepo ancestor directories. When the selected manager differs from the detected one, resolve its latest stable version instead of reusing the ancestor manager’s version. Add snapshot coverage for creating a pnpm project beneath an npm ancestor and update the package manager detection RFC.

Fixes #2208

Keep existing monorepo package managers authoritative while allowing standalone creates to override package-manager signals inherited from ancestor directories.
@netlify

netlify Bot commented Jul 23, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit c2c1f7b
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a646d51f9cb3700081349c3

@jong-kyung

Copy link
Copy Markdown
Collaborator Author

@codex review

@jong-kyung jong-kyung self-assigned this Jul 23, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: b1545b18d7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jong-kyung
jong-kyung marked this pull request as ready for review July 23, 2026 06:02

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b1545b18d7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rfcs/package-manager-detection.md Outdated
@jong-kyung

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: e8f10cf329

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jong-kyung
jong-kyung requested review from fengmk2 and wan9chi July 23, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vp create --package-manager is silently overridden by package manager detection from ancestor directories

1 participant