refactor: extract check command into its own module#1350
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 11, 2026
Merged
refactor: extract check command into its own module#1350graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
|
@codex review |
cpojer
approved these changes
Apr 9, 2026
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
fengmk2
force-pushed
the
windows-installer
branch
from
7bb82d7 to
2b0a367
Compare
fengmk2
force-pushed
the
windows-installer
branch
from
2b0a367 to
2e2720b
Compare
fengmk2
force-pushed
the
refactor-cli.rs
branch
2 times, most recently
from
5ad7900 to
e9cf38e
Compare
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e9cf38e. Configure here.
fengmk2
force-pushed
the
windows-installer
branch
from
d49974c to
1d5ca4a
Compare
fengmk2
force-pushed
the
refactor-cli.rs
branch
from
e9cf38e to
7b8da63
Compare
fengmk2
force-pushed
the
refactor-cli.rs
branch
from
7b8da63 to
fd25de3
Compare
fengmk2
force-pushed
the
windows-installer
branch
2 times, most recently
from
9bb496d to
c7f59c6
Compare
fengmk2
force-pushed
the
refactor-cli.rs
branch
3 times, most recently
from
6bac44a to
3fc0253
Compare
Merge activity
|
Move the check command's orchestration logic, output analysis types, and parsing functions from cli.rs into a dedicated check/ directory, following the same pattern as exec/. cli.rs: 1,778 → 1,314 lines check/mod.rs: execute_check() orchestration (247 lines) check/analysis.rs: types, parsers, formatters (255 lines) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Primarily a refactor, but it changes how `vp check` is dispatched and how fmt/lint output is captured/parsed, which could affect exit codes or CI output stability. > > **Overview** > Refactors the `vp check` implementation by extracting its orchestration and output-parsing logic from `cli.rs` into a new `check/` module (`check/mod.rs` + `check/analysis.rs`), keeping the same fmt→lint flow and `--fix` re-format pass. > > Updates `cli.rs` visibility to reuse `resolve_universal_vite_config` and `resolve_and_capture_output`, and switches the `Check` subcommand handler to delegate to `crate::check::execute_check`; related `LintMessageKind` tests move with the extraction. Documentation in `rfcs/check-command.md` is updated to reflect the new module layout and cache-input helper naming. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit e9cf38e. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
graphite-app
bot
force-pushed
the
windows-installer
branch
from
791b25d to
6a9eb3d
Compare
graphite-app
bot
force-pushed
the
refactor-cli.rs
branch
from
3fc0253 to
6ebba00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the check command's orchestration logic, output analysis types,
and parsing functions from cli.rs into a dedicated check/ directory,
following the same pattern as exec/.
cli.rs: 1,778 → 1,314 lines
check/mod.rs: execute_check() orchestration (247 lines)
check/analysis.rs: types, parsers, formatters (255 lines)
Note
Medium Risk
Primarily a refactor, but it changes how
vp checkis dispatched and how fmt/lint output is captured/parsed, which could affect exit codes or CI output stability.Overview
Refactors the
vp checkimplementation by extracting its orchestration and output-parsing logic fromcli.rsinto a newcheck/module (check/mod.rs+check/analysis.rs), keeping the same fmt→lint flow and--fixre-format pass.Updates
cli.rsvisibility to reuseresolve_universal_vite_configandresolve_and_capture_output, and switches theChecksubcommand handler to delegate tocrate::check::execute_check; relatedLintMessageKindtests move with the extraction. Documentation inrfcs/check-command.mdis updated to reflect the new module layout and cache-input helper naming.Reviewed by Cursor Bugbot for commit e9cf38e. Configure here.