🧪 [Testing Improvement] Add Out-Of-Memory test for HashMap resize logic#70
🧪 [Testing Improvement] Add Out-Of-Memory test for HashMap resize logic#70
Conversation
Co-authored-by: ulac000000 <132948319+ulac000000@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: The testing gap addressed is the missing coverage for the Out-Of-Memory (OOM) handling branch within
HashMap.resize().📊 Coverage: This patch introduces a robust test case covering the exact scenario where the
try self.allocator.allocfails when the HashMap naturally reaches its threshold and attempts to double its capacity. It usesstd.testing.FailingAllocatorwith.fail_index = 1to successfully initialize the struct but simulate allocation failure strictly during theresizefunction called insideput. It checks thaterror.OutOfMemoryis accurately returned and asserts the integrity of all pre-existing elements.✨ Result: The test suite now guarantees data preservation during internal allocation failures on resizing. Code coverage in
echo-core-zig/src/data/hashmap.zigis improved and ensures no items are corrupted when reaching memory limits.PR created automatically by Jules for task 124247147783657865 started by @ulac000000