Skip to content

🧪 Add test for greedyNextToken with negative logits#63

Open
void0x14 wants to merge 1 commit intomainfrom
jules-4016723168567843465-8a3e69cd
Open

🧪 Add test for greedyNextToken with negative logits#63
void0x14 wants to merge 1 commit intomainfrom
jules-4016723168567843465-8a3e69cd

Conversation

@void0x14
Copy link
Copy Markdown
Owner

🎯 What: The testing gap in Engine.greedyNextToken was addressed by adding an edge case test where all valid logits are negative.
📊 Coverage: The scenario where logits are negative is now fully tested, preventing the uninitialized 0xaa (-3.03e-13 in f32) values from incorrectly passing as the maximum.
Result: Test coverage for greedyNextToken is improved, and logic fragility around negative logits is solved.


PR created automatically by Jules for task 4016723168567843465 started by @ulac000000

Co-authored-by: ulac000000 <132948319+ulac000000@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant