🧪 Add test for greedyNextToken with negative logits#63
Conversation
Co-authored-by: ulac000000 <132948319+ulac000000@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: The testing gap in
Engine.greedyNextTokenwas addressed by adding an edge case test where all valid logits are negative.📊 Coverage: The scenario where logits are negative is now fully tested, preventing the uninitialized
0xaa(-3.03e-13 in f32) values from incorrectly passing as the maximum.✨ Result: Test coverage for
greedyNextTokenis improved, and logic fragility around negative logits is solved.PR created automatically by Jules for task 4016723168567843465 started by @ulac000000