Skip to content

harper-cli: update to 2.6.0.#61328

Open
Bnyro wants to merge 1 commit into
void-linux:masterfrom
Bnyro:harper-cli
Open

harper-cli: update to 2.6.0.#61328
Bnyro wants to merge 1 commit into
void-linux:masterfrom
Bnyro:harper-cli

Conversation

@Bnyro

@Bnyro Bnyro commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc

@Bnyro
Bnyro marked this pull request as draft July 4, 2026 19:30

@meator meator left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--- a/srcpkgs/harper-cli/template
+++ b/srcpkgs/harper-cli/template
@@ -39,6 +39,6 @@ pre_install() {
 harper-ls_package() {
 	short_desc+=" - LSP"
 	pkg_install() {
-		vbin "target/${RUST_TARGET}/release/harper-cli" harper-ls
+		vbin "target/${RUST_TARGET}/release/harper-ls" harper-ls
 	}
 }

This was a fun one to debug.

@Bnyro

Bnyro commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author
--- a/srcpkgs/harper-cli/template
+++ b/srcpkgs/harper-cli/template
@@ -39,6 +39,6 @@ pre_install() {
 harper-ls_package() {
 	short_desc+=" - LSP"
 	pkg_install() {
-		vbin "target/${RUST_TARGET}/release/harper-cli" harper-ls
+		vbin "target/${RUST_TARGET}/release/harper-ls" harper-ls
 	}
 }

This was a fun one to debug.

Ouch, good catch, thank you!

Not sure what happened there :)

@Bnyro

Bnyro commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Builds fail with

pkg-config exited with status code 1
  > PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 pkg-config --libs --cflags gdk-3.0 'gdk-3.0 >= 3.22'

  The system library `gdk-3.0` required by crate `gdk-sys` was not found.
  The file `gdk-3.0.pc` needs to be installed and the PKG_CONFIG_PATH environment variable must contain its parent directory.
  The PKG_CONFIG_PATH environment variable is not set.

  HINT: if you have installed the library, try setting PKG_CONFIG_PATH to the directory containing `gdk-3.0.pc`.

i.e. a missing gtk+3 dependency. However, gtk3 is only required for building the desktop app of harper, but we're explicitly setting --package harper-cli --package harper-ls in make_build_args, so I don't understand why it still tries to build the desktop package? :/

@Bnyro

Bnyro commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Oh, make_check fails, not make_build - I'm stupid

@Bnyro
Bnyro marked this pull request as ready for review July 16, 2026 11:33
@Bnyro
Bnyro force-pushed the harper-cli branch 2 times, most recently from 46c887b to 06d96c0 Compare July 16, 2026 11:39
@meator

meator commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

I'd make the least ammount of changes to harper's build system to get rid of unnecessary dependencies, make a patch of it, include it in the update and contact upstream.

I don't know Rust nor Cargo, so I can't help much here.

@Bnyro

Bnyro commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

I'd make the least ammount of changes to harper's build system to get rid of unnecessary dependencies, make a patch of it, include it in the update and contact upstream.

I finally managed to properly disable building and tests for the desktop package, so we should be good now, so gtk and glib are not needed for compilation anymore. So it already works without upstream patches, I've just been making it too complicated for myself.

Thanks for your help @meator <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants