Skip to content

helvum: update to 0.6.2.#60824

Merged
Duncaen merged 1 commit into
void-linux:masterfrom
gnpaone:master
May 31, 2026
Merged

helvum: update to 0.6.2.#60824
Duncaen merged 1 commit into
void-linux:masterfrom
gnpaone:master

Conversation

@gnpaone
Copy link
Copy Markdown
Contributor

@gnpaone gnpaone commented May 30, 2026

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64-libc

@gnpaone
Copy link
Copy Markdown
Contributor Author

gnpaone commented May 30, 2026

@0x5c Hi, could you please help get this PR merged when you have a moment? Thanks!

@Duncaen Duncaen merged commit 0a013a5 into void-linux:master May 31, 2026
8 checks passed
@0x5c
Copy link
Copy Markdown
Contributor

0x5c commented Jun 1, 2026

That post_patch() block is from the 0.4.1 update, where a bug in the pipewire crate would prevent compilation for 32-bit architectures. By the time of the following Helvum release, the proper fix had been released in a pipewire version that hadn't made its way to Helvum yet, so the cargo.toml patching was simplified to use the fixed pipewire-rs version.

Now that Helvum is using an up-to-date pipewire crate, what was the rationale behind keeping the patching in this PR? I have confirmed that Helvum 0.6.2 builds properly without any patching, and is doing so using the correct crate versions for both pirewire and libspa.

Side note, you only became a maintainer of Helvum 3 weeks ago, with no prior history of contributions. The git log since then has been rather strange and erratic. I have many questions, and it seems I'm not the only one.

It's also very odd to see an attempt at adopting a package -without any contribution history- side-by-side with these other package update PRs for other distros.

@gnpaone
Copy link
Copy Markdown
Contributor Author

gnpaone commented Jun 1, 2026

Sorry about that. I didn't touch post_patch() because I assumed there was still a reason for it to be there, especially since it wasn't removed until 0.5.1. From your explanation, it sounds like it is no longer needed and I agree it can be removed.

Regarding the adoption request, I certainly didn't intend to offend anyone or give the impression that I was trying to take over the package. My understanding was simply that the package had not been updated for a considerable period despite newer releases being available, so I submitted the PR in an attempt to help keep it up to date. The same motivation applied to my contributions elsewhere.

I understand the concerns that have been raised and have tried to address them in the discussions where they were brought up. I'm also continuing to work on outstanding issues. I welcome review, feedback, and questions about any of my contributions and I have already addressed the feedback given for some of my work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants