fix: Use data.get() for smooth key retrieval#27
Open
phorward wants to merge 1 commit into
Open
Conversation
This sometimes causes exceptions when parsing using-skels where a key wasn't provided.
phorward
added
the
Priority: Low
| def _extractor_for_simple_bones(key, conversion_function=str, **kwargs): | ||
| def extractor_for_simple_bones(data): | ||
| yield key, conversion_function(data[key]) | ||
| yield key, conversion_function(data.get(key, "")) |
Contributor
There was a problem hiding this comment.
Suggested change
| yield key, conversion_function(data.get(key, "")) | |
| yield key, conversion_function(data.get(key, None)) |
Why not None ?
Member
There was a problem hiding this comment.
@ArneGudermann If you want None, you can omit the second paramter complety, because it's the default. ;)
Suggested change
| yield key, conversion_function(data.get(key, "")) | |
| yield key, conversion_function(data.get(key)) |
But I think an empty string is more robust for data processing (csv export)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sometimes causes exceptions when parsing using-skels where a key wasn't provided.