fix(plugin-rsc): expose encodeFormAction option type and re-export encodeReply from ssr#1280
Open
dai-shi wants to merge 1 commit into
Open
fix(plugin-rsc): expose encodeFormAction option type and re-export encodeReply from ssr#1280dai-shi wants to merge 1 commit into
dai-shi wants to merge 1 commit into
Conversation
…codeReply from ssr
Author
|
Can anyone trigger preview please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two gaps hit when a framework customizes React's progressive-enhancement
form encoding during SSR. The first is required for wakujs/waku's pending
change; the second is a type-only convenience.
Missing export (blocking). A custom
encodeFormActionthat reproducesReact's default
$ACTION_REF_field encoding needsencodeReply, whichthe vendored
client.edgeexports but the/ssr(and/react/ssr)wrappers do not re-export. Importing it from
/ssr, the same entry thatprovides
createFromReadableStream, guarantees the serializer matchesthe flight-client instance in use regardless of which react-server-dom
build or version is active, and avoids downstream deep imports into
vendor/. One-line re-export:Type gap.
createFromReadableStreamfrom@vitejs/plugin-rsc/ssrspreads
...optionsinto the vendored flight client, soencodeFormActionworks at runtime today, but the published options type(
CreateFromReadableStreamEdgeOptions) omits it, forcing a cast: