Skip to content

Add i18n table links#2560

Merged
hupf merged 1 commit into
mainfrom
feature/106-i18n-table-links
May 13, 2026
Merged

Add i18n table links#2560
hupf merged 1 commit into
mainfrom
feature/106-i18n-table-links

Conversation

@hupf
Copy link
Copy Markdown
Contributor

@hupf hupf commented May 12, 2026

Closes these issues:
https://gitlab.lindas.admin.ch/bafu/bafu-visualize/visualization-tool/-/issues/106
https://gitlab.lindas.admin.ch/bafu/bafu-visualize/visualize/-/issues/765

This PR extends the links attributes of table diagrams such that a language-specific base URL can be defined (currently it is only possible to define a single base URL across all languages). As implemented, there is no fallback mechanism between languages; if a language has no base URL defined, the column won't be linked. Previous chart configs with a base URL defined, will be migrated, such that this URL will be used for each language.

How to test

  • Prior to this change, create a chart diagram for the "Federal Councillors, Party, Canton, Terms" cube, enable the "Enable links" option and define a "Base URL" then choose the "Name" column as source and target column. The name column in the table should now have a link.
  • Then with this change, open the previously created chart. The name column should still have the link (also if you switch the language).
  • Additionally, with the change, create a new chart and define per language base URLs. The name column should have the language-specific link, depending on the currently active language.

  • I added a CHANGELOG entry
  • I made a self-review of my own code
  • I wrote tests for the changes (if applicable)
  • I wrote configurator and chart config migrations (if applicable)

@hupf hupf self-assigned this May 12, 2026
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
visualization-tool Ready Ready Preview, Comment May 13, 2026 6:14am

Request Review

@hupf hupf changed the title Feature/ i18n table links Add i18n table links May 12, 2026
@hupf hupf force-pushed the feature/106-i18n-table-links branch from 243c6a2 to b8e1ffc Compare May 12, 2026 13:27
@hupf hupf marked this pull request as ready for review May 12, 2026 13:30
@hupf hupf requested a review from mburri May 12, 2026 13:30
Copy link
Copy Markdown
Contributor

@mburri mburri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@hupf hupf force-pushed the feature/106-i18n-table-links branch from b8e1ffc to d423358 Compare May 13, 2026 06:05
@hupf hupf merged commit 237d9ad into main May 13, 2026
15 of 16 checks passed
@hupf hupf deleted the feature/106-i18n-table-links branch May 13, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants