Skip to content

Strip build-only tooling from the finished image #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eiriksm wants to merge 6 commits into
base: main
Choose a base branch
from
+25 −4
Open

Strip build-only tooling from the finished image #180

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9b2fb0c
Strip build-only tooling from the finished image
claude Jul 7, 2026
3cec18f
Fix build-deps virtual package clobbering itself mid-script
claude Jul 7, 2026
4b819d0
Merge branch 'main' into claude/build-tools-cleanup-xmpagv
eiriksm Jul 8, 2026
701a140
Update php-install.sh
eiriksm Jul 8, 2026
3acfb55
Explicitly keep sasl, unixodbc and file across the build-deps cleanup
claude Jul 8, 2026
0624544
Clean up the two remaining stray build-only packages
claude Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 25 additions & 4 deletions php-install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
set -eu

apk add --no-cache unixodbc-dev brotli-dev gmp-dev yaml-dev samba-dev libldap openldap-dev pcre-dev libxslt-dev imap-dev sudo git libpng libjpeg libpq libxml2 mysql-client openssh-client rsync patch bash imagemagick libzip-dev \
imagemagick-libs unixodbc-dev rabbitmq-c rabbitmq-c-dev mpdecimal-dev gettext gettext-dev imagemagick-dev librdkafka-dev autoconf g++ make icu-dev libpng-dev libjpeg-turbo-dev postgresql-dev libxml2-dev bzip2-dev icu icu-dev libmemcached-dev linux-headers $PHPIZE_DEPS
apk add --no-cache sudo git libpng libjpeg libpq libxml2 libldap cyrus-sasl unixodbc file mysql-client openssh-client rsync patch bash imagemagick imagemagick-libs rabbitmq-c gettext icu

apk add --no-cache --virtual .build-deps unixodbc-dev brotli-dev gmp-dev yaml-dev samba-dev openldap-dev pcre-dev libxslt-dev imap-dev libzip-dev \
rabbitmq-c-dev mpdecimal-dev gettext-dev imagemagick-dev librdkafka-dev autoconf g++ make icu-dev libpng-dev libjpeg-turbo-dev postgresql-dev libxml2-dev bzip2-dev libmemcached-dev linux-headers pax-utils $PHPIZE_DEPS

case $PHP_VERSION in
8.6*)
Expand Down Expand Up @@ -247,7 +249,7 @@ esac
# gd has slightly different build arguments on newer PHP.
case $PHP_VERSION in
7.4|8.*)
apk add --no-cache oniguruma-dev
apk add --no-cache --virtual .build-deps-gd oniguruma-dev
docker-php-ext-configure gd --with-jpeg=/usr
;;
*)
Expand Down Expand Up @@ -289,7 +291,7 @@ docker-php-ext-enable imagick

case $PHP_VERSION in
8.4*|8.5*)
apk add --no-cache krb5-dev
apk add --no-cache --virtual .build-deps-imap krb5-dev
# If we really need it.
php -m | grep -q '^imap$' || yes | pecl install imap
docker-php-ext-enable imap
Expand Down Expand Up @@ -322,6 +324,25 @@ case $PHP_VERSION in
;;
esac

runDeps="$( \
scanelf --needed --nobanner --format '%n#p' --recursive /usr/local/lib/php/extensions 2>/dev/null \
| tr ',' '\n' \
| sort -u \
| awk 'system("[ -e /usr/local/lib/" $1 " ]") == 0 { next } { print "so:" $1 }' \
)"
if [ -n "$runDeps" ]; then
apk add --no-cache --virtual .phpexts-rundeps $runDeps
fi
extraBuildDeps=""
for extra in .build-deps-gd .build-deps-imap; do
if apk info -e "$extra" >/dev/null 2>&1; then
extraBuildDeps="$extraBuildDeps $extra"
fi
done
apk del --no-network .build-deps $extraBuildDeps

docker-php-source delete

mkdir ~/.ssh/
ssh-keyscan -t rsa git.drupal.org >> ~/.ssh/known_hosts
ssh-keyscan -t rsa gitlab.com >> ~/.ssh/known_hosts
Expand Down
Loading