Fix command output check

[Shougo]

#467

Summary by CodeRabbit

• Bug Fixes
  • Enhanced version detection reliability by improving error handling to ensure consistent fallback behavior when version information cannot be retrieved

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cbdafa61-1a7f-4e76-a993-9fcbec6fad41

📥 Commits

Reviewing files that changed from the base of the PR and between 1df7a02 and b224633.

📒 Files selected for processing (1)

• denops/@denops-private/version.ts

---

📝 Walkthrough

Walkthrough

The getVersionOr function now moves its try block boundary earlier to catch errors during command.output() execution, not just subsequent parsing. Any exception thrown during command execution now triggers the fallback, while the existing behavior for non-success exits and parse/decode errors remains unchanged.

Changes

Error Handling for Command Execution

Layer / File(s)	Summary
Error handling for git describe execution denops/@denops-private/version.ts	getVersionOr relocates the try block start to wrap command.output(), catching execution errors and returning the fallback value alongside existing parse error handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A little try-catch hops up high, 🐰
To catch errors the command might fly,
Before parsing comes into play,
Fallback stands guard along the way! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fix command output check' directly relates to the main change: wrapping git describe execution in a try block to properly check command output and handle exceptions.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fallback_version

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}