Fix memory leak: use weak self in timeline observation loop#96
Merged
viktorstrate merged 1 commit intoviktorstrate:mainfrom Apr 9, 2026
Merged
Conversation
Owner
|
Neat with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TimelineViewController.listenForFocusTimelineItem()useswithObservationTrackingwith a recursiveonChangeclosure to watch for focused event changes. The closure capturedselfstrongly, meaning the observation system held theTimelineViewControlleralive indefinitely — even after switching rooms. SinceTimelineViewControllerholdsLiveTimelinewhich holdsLiveRoom, the entire timeline object graph accumulated with each room switch.[weak self]in theonChangeclosure so the observation chain breaks when the view controller is deallocated.Relates to #89
Verification with
heapYou can verify the fix using the
heapcommand-line tool. Get the PID of the running app withpgrep -x Mactrixor from Activity Monitor, then:heap <pid> | grep -E 'LiveTimeline|LiveRoom'— should show 1 of eachheapcommand again — without the fix the counts match the number of room switches; with the fix they stay at 1