Fix memory leak: return early on image cache hit in MessageImageView#92
Closed
beezly wants to merge 8 commits intoviktorstrate:mainfrom
Closed
Fix memory leak: return early on image cache hit in MessageImageView#92beezly wants to merge 8 commits intoviktorstrate:mainfrom
beezly wants to merge 8 commits intoviktorstrate:mainfrom
Conversation
The .task block checked the NSCache but never returned on a hit, causing getMediaContent to be called on every channel visit even for already-cached images. Adds the missing `return` to match the pattern used in MatrixImageView and AvatarImage. Fixes viktorstrate#89 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Superseded by a clean branch based on origin/main — see new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MessageImageView's.taskblock checkedNSCacheon cache hit but never returned, causinggetMediaContentto be called on every channel visit even for already-cached imagesreturnafter a cache hit — a one-line fix matching the pattern already used inMatrixImageViewandAvatarImageOSLogdebug instrumentation: before the fix, every return to a channel showedcache HITimmediately followed by a redundant network fetch; after the fix, cache hits return early with no network callTest plan
Fixes #89