Deterministic code generation for platform#92
Open
and-bezzir wants to merge 1 commit into
Open
Conversation
- column discovery: keep the discovery SQL valid when stripping predicate-builder
templates (Build("WHERE") -> WHERE 1=1, other builders dropped) and trim the
wrapping ( ... ) of derived-table views before falsifying, so templated /
aggregate views resolve their real column types from the DB instead of failing
discovery and falling back to string/not-null. Applied in both the shape
detector and discoverysql.PrepareDiscoverySQL (internal engine path).
- gofmt generated Go (GenerateOutputCode + asset upload) so the EmbedFS method
layout is stable across regenerations.
- sort route entries by SourceURL in createPathFiles so paths.yaml is written in
a deterministic order.
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes Datly code generation deterministic so regenerating platform assets no longer produces spurious diffs.
Build("WHERE")->WHERE 1=1, other builders dropped) and trim the wrapping( ... )of derived-table views before falsifying, so templated / aggregate views resolve their real column types from the DB instead of failing discovery and falling back to string/not-null. Applied in both the shape detector anddiscoverysql.PrepareDiscoverySQL(internal engine path).GenerateOutputCode+ asset upload) so theEmbedFSmethod layout is stable across regenerations.SourceURLincreatePathFilessopaths.yamlis written in a deterministic order.Made with Cursor