feat(ARC-3833): add double banner content block - #385
Open
RobbeBierebeeck wants to merge 4 commits into
Open
Conversation
Two mirrored halves, each a clickable path with a label, up to three icons, an image and its own text/background colour. https://meemoo.atlassian.net/browse/ARC-3833 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KfHyE7TNyMnk3QALg89RK9
reunefe
requested changes
Aug 14, 2026
reunefe
reviewed
Aug 14, 2026
Comment on lines
+48
to
52
| <IconComponent | ||
| key={`c-block-double-banner__icon-${index}-${iconIndex}-${icon}`} | ||
| className="c-block-double-banner__icon" | ||
| name={icon as IconName} | ||
| aria-hidden | ||
| name={resolveIconName(icon)} | ||
| /> |
Contributor
There was a problem hiding this comment.
Waarom wijk je plots af van de bestaande component die dat intern allemaal al doet?
bertyhell
approved these changes
Aug 14, 2026
Comment on lines
+29
to
+31
| &:focus-visible { | ||
| @include focus.focus; | ||
| } |
Contributor
There was a problem hiding this comment.
i reworked the mixin so you can now use this:
Suggested change
| &:focus-visible { | |
| @include focus.focus; | |
| } | |
| @include focus.focus; |
Comment on lines
+122
to
+125
| AvoCoreContentPickerType.CONTENT_PAGE, | ||
| AvoCoreContentPickerType.INTERNAL_LINK, | ||
| AvoCoreContentPickerType.EXTERNAL_LINK, | ||
| AvoCoreContentPickerType.ANCHOR_LINK, |
Contributor
There was a problem hiding this comment.
Suggested change
| AvoCoreContentPickerType.CONTENT_PAGE, | |
| AvoCoreContentPickerType.INTERNAL_LINK, | |
| AvoCoreContentPickerType.EXTERNAL_LINK, | |
| AvoCoreContentPickerType.ANCHOR_LINK, | |
| AvoCoreContentPickerType.CONTENT_PAGE, | |
| AvoCoreContentPickerType.INTERNAL_LINK, | |
| AvoCoreContentPickerType.EXTERNAL_LINK, | |
| AvoCoreContentPickerType.ANCHOR_LINK, | |
| AvoCoreContentPickerType.IE_OBJECT, | |
| AvoCoreContentPickerType.FILE, |
Contributor
There was a problem hiding this comment.
@bertyhell Klopt dit wel? want het is:
Bestemming van een klik op de CTA:
Dit kan een URL of intern pad op hetarchief.be zijn.
De bestemming wordt steeds getoond op dezelfde tab.
Dus File lijkt me niet juist, en Object ben ik ook niet zeker. ANders staat het steeds expliciet mee opgelijst en in deze FA dus niet. Lijkt me dan ook dat wel juist was 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://meemoo.atlassian.net/browse/ARC-3833
Adds the double banner content block and follows up with responsive layout, validation and accessibility fixes.