fix(ARC-3848): wcag text colors on content block backgrounds - #383
Open
RobbeBierebeeck wants to merge 11 commits into
Open
fix(ARC-3848): wcag text colors on content block backgrounds#383RobbeBierebeeck wants to merge 11 commits into
RobbeBierebeeck wants to merge 11 commits into
Conversation
added 7 commits
August 12, 2026 21:26
Split GET_DARK_BACKGROUND_COLOR_OPTIONS into an AVO variant (unchanged) and an archief variant sourced from the delivered colour list: only black and old pink backgrounds need white text, ocean green and sea green need black (the old shared list had that backwards).
reunefe
requested changes
Aug 13, 2026
reunefe
requested changes
Aug 14, 2026
Comment on lines
+42
to
+46
| primary: string; | ||
| /** Muted text: captions, subtitles, metadata. Absent when design specified no second color. */ | ||
| secondary?: string; | ||
| /** Underlined link text. Absent when design specified no link color. */ | ||
| hyperlink?: string; |
Contributor
There was a problem hiding this comment.
Suggested change
| primary: string; | |
| /** Muted text: captions, subtitles, metadata. Absent when design specified no second color. */ | |
| secondary?: string; | |
| /** Underlined link text. Absent when design specified no link color. */ | |
| hyperlink?: string; | |
| primary: Color; | |
| /** Muted text: captions, subtitles, metadata. Absent when design specified no second color. */ | |
| secondary?: Color; | |
| /** Underlined link text. Absent when design specified no link color. */ | |
| hyperlink?: Color; |
Gaan we secondary en hyperlink niet ook verplicht maken. Als er kleuren zijn waar dit niet ingesteld was op de PDF zou ik ze eventueel gewoon gelijk zetten aan de primary color en de hyperlink kleur de default hyperlink kleur laten gebruiken
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://meemoo.atlassian.net/browse/ARC-3848
Sets the text color on every content block that renders text on an admin-picked background color, computed from the WCAG AA contrast rule instead of a hand-maintained list.