Bump cryptography 50.0.0 + aiohttp 3.14.3 in visual-retrieval-colpali (3 Mend HIGH CVEs) - #1987
Open
odosk wants to merge 1 commit into
Open
Bump cryptography 50.0.0 + aiohttp 3.14.3 in visual-retrieval-colpali (3 Mend HIGH CVEs)#1987odosk wants to merge 1 commit into
odosk wants to merge 1 commit into
Conversation
…colpali Clears 3 Mend HIGH CVEs in src/legacy-requirements.txt: CVE-2026-69247, CVE-2026-69249 (cryptography 48.0.1) CVE-2026-69244 (aiohttp 3.14.1) Both are pinned only by lower-bound constraints upstream (pyvespa: cryptography>=48.0.1; fsspec/datasets: aiohttp!=4.0.0a*), so the bumps stay within every declared range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
cryptographyandaiohttpinvisual-retrieval-colpali/src/legacy-requirements.txtto the first releases that patch three Mend HIGH findings. Two other CVEs Mend reports against this repo have no released upstream fix and are documented below rather than papered over.Changed Files
visual-retrieval-colpali/src/legacy-requirements.txtcryptography:48.0.1→50.0.0aiohttp:3.14.1→3.14.3CVEs Addressed
Verified against OSV.dev:
EnvelopedDatadecryption exposes a Bleichenbacher oracle through distinguishable errors and timing. OSV: introduced44.0.0, fixed50.0.0.49.0.0.3.14.3.Both packages are transitive and bounded only from below, so neither bump violates a declared range:
sentence-transformers@ 5.5.1or os.path.exists(model_name_or_path)short-circuit inimport_module_class(sentence_transformers/util/misc.py), which satisfies the trust gate for any local path. That clause is still present in the current 5.6.1 release, carrying an explicit upstreamTODO(v6.0): remove the 'or os.path.exists(...)' short-circuit ... requiring trust_remote_code for local custom code (#3801). Upstream has deprecated it with aFutureWarningand deferred removal to v6.0, so bumping to 5.6.1 would be a no-op for this CVE. Tracking upstream issue: huggingface/sentence-transformers#3801.torchvision@ 0.28.00.28.0is still the newest version on PyPI. Source file isreverse-image-search/script/requirements.txt(torchvision>=0.20.0), which already floats to latest. Re-check on the next torchvision release.transformerstransformersCVE-2025-14920last_affected 4.54.1; everytransformerspin in this repo is far newer (5.12.0).CVE-2025-14920 in
transformers— the ZDI advisory is bounded atlast_affected: 4.54.1. This repo pinstransformers==5.12.0invisual-retrieval-colpali/pyproject.tomlandtransformers>=5.0.0inreverse-image-search/script/requirements.txt; neither can resolve into the affected range. The same finding has been raised and dismissed on ten other Vespa repos. Suggested improvement for Mend: honour the advisory'slast_affectedbound instead of reporting everytransformersartifact regardless of version.Implementation Notes
Why these two pins were edited directly rather than recompiling.
legacy-requirements.txtis auv pip compileoutput, so the normal move is to regenerate it. That is currently impossible —visual-retrieval-colpali/pyproject.tomlno longer resolves:Editing the two pins in place matches how this file has actually been maintained — Renovate has landed five surgical single-pin security bumps to it (
pillow,httplib2,setuptools,torch,pyasn1).Both were found while validating this change and need an owner decision; neither is caused by this PR:
pyproject.tomlis unsatisfiable (output above).transformers==5.12.0conflicts with thevidore-benchmark>=5.0.0,<5.1.0→sentence-transformers<4.0.0→transformers<5.0.0chain. Until this is reconciled the documenteduvinstall path in the README cannot work, and the file can never be regenerated.legacy-requirements.txtis itself unsatisfiable, independently of this PR. Verified on unmodifiedmaster:torch→2.13.0security bump moved it pastcolpali-engine's ceiling. Sopip install -r src/legacy-requirements.txt(the path the README gives for the HuggingFace space) already fails onmastertoday.This PR deliberately does not attempt to fix either — both need a real dependency-set decision (pin
vidore-benchmarklower, drop it, or move offcolpali-engine0.3.x), which is out of scope for a CVE bump.Pre-existing CI failure (not caused by this PR)
test / htmlproofer(workflow Link checker) fails on this PR and on unmodifiedmaster— six consecutive failures onmasterfrom 2026-08-03 through 2026-08-05. The cause is a dead external link, unrelated to this change:Left alone deliberately: fixing an unrelated dead doc link does not belong in a CVE bump.
Verification
fixedevents from those records, not Mend's claimpyvespa/fsspec/datasetsrequires_distinspected on PyPI to confirm no upper bound is crosseduv pip install --dry-run -r src/legacy-requirements.txtrun in apython:3.10-slimcontainer on both unmodifiedmasterand this branch — identical failure on each, confirming this change neither introduces nor worsens the pre-existing conflict