Skip to content

Derive Hook type from HookSchema#2822

Closed
NathanColosimo wants to merge 2 commits into
mainfrom
codex/derive-hook-type
Closed

Derive Hook type from HookSchema#2822
NathanColosimo wants to merge 2 commits into
mainfrom
codex/derive-hook-type

Conversation

@NathanColosimo

Copy link
Copy Markdown
Contributor

Summary

  • derive the public Hook type directly from HookSchema
  • remove the duplicated field declaration so the schema remains the single source of truth

Follow-up to #2790.

Test plan

  • pnpm --filter @workflow/world build
  • typecheck world-local, world-postgres, world-vercel, and web-shared
  • pnpm vitest run src/storage.test.ts -t hook in packages/world-local

@vercel

vercel Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview, Comment Jul 8, 2026 8:30pm
example-nextjs-workflow-webpack Ready Ready Preview, Comment Jul 8, 2026 8:30pm
example-workflow Ready Ready Preview, Comment Jul 8, 2026 8:30pm
workbench-astro-workflow Ready Ready Preview, Comment Jul 8, 2026 8:30pm
workbench-express-workflow Ready Ready Preview, Comment Jul 8, 2026 8:30pm
workbench-fastify-workflow Ready Ready Preview, Comment Jul 8, 2026 8:30pm
workbench-hono-workflow Ready Ready Preview, Comment Jul 8, 2026 8:30pm
workbench-nitro-workflow Ready Ready Preview, Comment Jul 8, 2026 8:30pm
workbench-nuxt-workflow Ready Ready Preview, Comment Jul 8, 2026 8:30pm
workbench-sveltekit-workflow Ready Ready Preview, Comment Jul 8, 2026 8:30pm
workbench-tanstack-start-workflow Ready Ready Preview, Comment Jul 8, 2026 8:30pm
workbench-vite-workflow Ready Ready Preview, Comment Jul 8, 2026 8:30pm
workflow-docs Ready Ready Preview, Comment, Open in v0 Jul 8, 2026 8:30pm
workflow-swc-playground Ready Ready Preview, Comment Jul 8, 2026 8:30pm
workflow-tarballs Ready Ready Preview, Comment Jul 8, 2026 8:30pm
workflow-web Ready Ready Preview, Comment Jul 8, 2026 8:30pm

@changeset-bot

changeset-bot Bot commented Jul 8, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 33f867e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

No benchmark result files found in benchmark-results

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

Passed Failed Skipped Total
❌ ▲ Vercel Production 1452 1 230 1683
✅ 💻 Local Development 1483 0 200 1683
✅ 📦 Local Production 1617 0 219 1836
✅ 🐘 Local Postgres 1617 0 219 1836
✅ 🪟 Windows 153 0 0 153
✅ 📋 Other 894 0 177 1071
Total 7216 1 1045 8262

❌ Failed Tests

▲ Vercel Production (1 failed)

express (1 failed):

  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01KX1Q2D8WC73N5MTCFS01Q51B | 🔍 observability

Details by Category

❌ ▲ Vercel Production
App Passed Failed Skipped
✅ astro 126 0 27
✅ example 126 0 27
❌ express 125 1 27
✅ fastify 126 0 27
✅ hono 126 0 27
✅ nextjs-turbopack 150 0 3
✅ nextjs-webpack 150 0 3
✅ nitro 126 0 27
✅ nuxt 126 0 27
✅ sveltekit 145 0 8
✅ vite 126 0 27
✅ 💻 Local Development
App Passed Failed Skipped
✅ astro-stable 128 0 25
✅ express-stable 128 0 25
✅ fastify-stable 128 0 25
✅ hono-stable 128 0 25
✅ nextjs-turbopack-canary 134 0 19
✅ nextjs-turbopack-stable 153 0 0
✅ nextjs-webpack-stable 153 0 0
✅ nitro-stable 128 0 25
✅ nuxt-stable 128 0 25
✅ sveltekit-stable 147 0 6
✅ vite-stable 128 0 25
✅ 📦 Local Production
App Passed Failed Skipped
✅ astro-stable 128 0 25
✅ express-stable 128 0 25
✅ fastify-stable 128 0 25
✅ hono-stable 128 0 25
✅ nextjs-turbopack-canary 134 0 19
✅ nextjs-turbopack-stable 153 0 0
✅ nextjs-webpack-canary 134 0 19
✅ nextjs-webpack-stable 153 0 0
✅ nitro-stable 128 0 25
✅ nuxt-stable 128 0 25
✅ sveltekit-stable 147 0 6
✅ vite-stable 128 0 25
✅ 🐘 Local Postgres
App Passed Failed Skipped
✅ astro-stable 128 0 25
✅ express-stable 128 0 25
✅ fastify-stable 128 0 25
✅ hono-stable 128 0 25
✅ nextjs-turbopack-canary 134 0 19
✅ nextjs-turbopack-stable 153 0 0
✅ nextjs-webpack-canary 134 0 19
✅ nextjs-webpack-stable 153 0 0
✅ nitro-stable 128 0 25
✅ nuxt-stable 128 0 25
✅ sveltekit-stable 147 0 6
✅ vite-stable 128 0 25
✅ 🪟 Windows
App Passed Failed Skipped
✅ nextjs-turbopack 153 0 0
✅ 📋 Other
App Passed Failed Skipped
✅ e2e-local-dev-nest-stable 128 0 25
✅ e2e-local-dev-tanstack-start- 128 0 25
✅ e2e-local-postgres-nest-stable 128 0 25
✅ e2e-local-postgres-tanstack-start- 128 0 25
✅ e2e-local-prod-nest-stable 128 0 25
✅ e2e-local-prod-tanstack-start- 128 0 25
✅ e2e-vercel-prod-tanstack-start 126 0 27

📋 View full workflow run


Some E2E test jobs failed:

  • Vercel Prod: failure
  • Local Dev: failure
  • Local Prod: success
  • Local Postgres: success
  • Windows: success

Check the workflow run for details.

Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
@NathanColosimo

Copy link
Copy Markdown
Contributor Author

Folded into #2790 in commit 0c40fb4, so this standalone follow-up is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant