Backport #2814: Bump e2e framework versions#2819
Conversation
* Fix SvelteKit config loading * Bump e2e framework versions Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 83a12c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
TooTallNate
left a comment
There was a problem hiding this comment.
The version-bump content itself is a faithful backport — I verified every non-lockfile hunk against the original #2814 (identical except two correct stable adaptations: sveltekit's vite devDep starts from 7.1.12 instead of 7.3.2 but lands on the same 7.3.6, and the nitro catalog hunk is correctly omitted because stable already pins 3.0.260610-beta), and pnpm install --frozen-lockfile + a full pnpm build succeed on the branch. But there's a real, deterministic breakage:
Blocking: the sveltekit workbench Vercel deployment fails on this PR, and it's caused by a missing prerequisite backport. The Vercel – workbench-sveltekit-workflow check fails with No Output Directory named "public" found after the Build completed, while the same check is green on the last 5 stable commits — so it's not a flake. Root cause: #2814 was stacked on #2802 ("Fix SvelteKit config loading", which changes packages/sveltekit/src/builder.ts), and #2802 was never backported to stable. This PR's lockfile refresh re-resolves the sveltekit workbench's caret ranges from @sveltejs/kit@2.55.0 up to 2.69.1 (plus newer adapter/plugin versions), which is exactly the territory that needs the config-loading fix — without it the adapter output isn't where the Vercel project expects. The original #2814 passed this same check on main because main has #2802.
Note the PR description's AI recommendation says this backport "includes a SvelteKit config-loading fix" — it doesn't; that text was inferred from the squash commit's message bullets, but the diff contains no sveltekit source changes.
Suggested path: backport #2802 to stable first (it should apply cleanly — packages/sveltekit/src/builder.ts exists there, and it carries its own changeset), then refresh this PR's lockfile on top. Folding #2802's changes into this PR would also work but loses the per-PR changeset/attribution granularity.
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (102 failed)redis (19 failed):
turso (83 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
|
|
Addressed the blocking SvelteKit review.
Verified locally:
The PR description now reflects that #2802 was added after the original automated backport. Please re-review when the refreshed checks finish. |
|
Final CI follow-up:
The remaining non-passing jobs are the explicitly non-blocking community-world lanes (Turso/Redis/MongoDB). The blocking SvelteKit deployment and runtime regression from the review are both resolved. Re-requesting review. |
Automated backport of #2814 to
stable(backport job run).This backports the e2e framework and integration dependency updates from #2814.
Follow-up fixes
The original automated backport omitted #2814’s prerequisite, #2802. That caused the upgraded SvelteKit workbench to recursively load its Vite config and prevented the Vercel adapter output from being generated.
@workflow/sveltekitpatch changeset in8353889c3.undicidependency directly to the private SvelteKit workbench in83a12c292. This is required onstable, whose older Svelte integration externalizes Undici instead of bundling it through the newer main-branch world-target plugin architecture.pnpm-lock.yamlfrom the resulting stable dependency graph.Merge conflicts in the original automated backport were resolved by AI (opencode with
anthropic/claude-opus-4.8). Please review those resolutions carefully before merging.Verification
pnpm install --frozen-lockfilepnpm buildAPP_NAME=sveltekit pnpm vitest run packages/core/e2e/local-build.test.tsVERCEL_DEPLOYMENT_ID=local pnpm --dir workbench/sveltekit buildThe adapter-vercel build produces
.vercel/output/config.json, static output, and function output.