Refresh Windows PATH for Hyper CLI session#8172
Open
alokshukla631 wants to merge 1 commit intovercel:canaryfrom
Open
Refresh Windows PATH for Hyper CLI session#8172alokshukla631 wants to merge 1 commit intovercel:canaryfrom
alokshukla631 wants to merge 1 commit intovercel:canaryfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Fixes #2823.
Updating the user PATH registry entry does not refresh the environment of the already-running Hyper process. As a result, the first Hyper session after install can still fail to resolve
hyperuntil Windows reloads environment variables.This change keeps the registry update, then refreshes Hyper's current process PATH so new shells spawned by Hyper can use the CLI immediately. Other terminal apps may still need to restart to pick up the registry change.
Testing
corepack yarn ava test/unit/cli-install.test.tscorepack yarn eslint app/utils/cli-install.ts app/utils/windows-path.ts test/unit/cli-install.test.tscorepack yarn test:unit