fix(mic-selector): don't change value on hover or arrow navigation - #467
Open
ephraimduncan wants to merge 1 commit into
Open
fix(mic-selector): don't change value on hover or arrow navigation#467ephraimduncan wants to merge 1 commit into
ephraimduncan wants to merge 1 commit into
Conversation
Contributor
|
@ephraimduncan is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once a microphone was selected (or
defaultValuewas set), merely hovering a row or arrowing through the open list fired the consumer'sonValueChangeand changed the trigger — as if that device had been chosen. The value now changes exactly once, when an item is activated, and opening the popover still highlights the currently selected device.Cause: cmdk's root value tracks the highlighted item, and
MicSelectorContentbound it to the public selection state — so once the component had a value (controlled mode), every pointer-move and arrow-key highlight change was reported as a selection.MicSelectorItem.onSelectwas already the correct commit point; the rootCommandnow receives onlydefaultValue={value}for initial highlight.Added two regressions: hover + ArrowDown/ArrowUp leaves the
onValueChangespy untouched (fails against the previous implementation), and keyboard activation fires exactly one change and closes the popover. 32/32 tests in the file pass.