fix(elements): keep branch switching with consumer className - #465
Open
ephraimduncan wants to merge 1 commit into
Open
fix(elements): keep branch switching with consumer className#465ephraimduncan wants to merge 1 commit into
ephraimduncan wants to merge 1 commit into
Conversation
Contributor
|
@ephraimduncan is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing any
classNametoMessageBranchContentmade every branch render at once, so the Previous/Next controls stopped producing a visible change. The consumer class sat in the props spread after the component's computedclassName, replacing thehidden/blockstate classes entirely. Even without a consumer class, tailwind-merge collapsed the conflictinggrid/blockutilities toblock, so the active branch never got its intended grid layout.The wrapper now derives display from a single state-dependent utility (
gridwhen active,hiddenotherwise) placed after the consumer class incn(), so branch visibility always wins the merge while consumer classes still extend the wrapper. Trade-off: a consumer can no longer override the active branch's display type.Regression test renders two branches with
className="rounded-md"and asserts exactly one wrapper isgridbefore and after clicking Next; full message suite passes 31/31 in Chromium.