fix(elements): keep last good jsx preview when streamed chunk fails to parse - #464
Open
ephraimduncan wants to merge 1 commit into
Open
fix(elements): keep last good jsx preview when streamed chunk fails to parse#464ephraimduncan wants to merge 1 commit into
ephraimduncan wants to merge 1 commit into
Conversation
Contributor
|
@ephraimduncan is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a streamed chunk failed to parse, the preview went blank instead of holding the last successful render — the broken chunk was recorded as the "last good" JSX and fed back to the parser. This happened because
react-jsx-parserreports parse errors synchronously during render, while the error tracking was reset in a passive effect after commit, so the render-phase error always lost to the post-commit reset. The reset now runs as render-phase derived state (the same patternJSXPreviewalready uses to clear its error), so a parse error vetoes the last-good update and the previous preview stays visible until a later chunk renders successfully. This also removes the extra error/re-render cycle each bad chunk triggered through the post-commitsetHadError(false).Added two streaming tests (plain and Strict Mode) driving good → invalid → good chunks; both fail before the fix by rendering an empty preview during the bad chunk. 30/30 pass in Chromium.