fix(elements): prevent invalid citation URL from crashing message render - #463
Open
ephraimduncan wants to merge 1 commit into
Open
fix(elements): prevent invalid citation URL from crashing message render#463ephraimduncan wants to merge 1 commit into
ephraimduncan wants to merge 1 commit into
Conversation
Contributor
|
@ephraimduncan is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A citation source like
example.com/nlp,/docs/setup, or other non-absolute model output previously threwTypeError: Invalid URLduring render, unmounting the entire message containing the citation instead of just degrading the badge.InlineCitationCardTriggernow guards the hostname parse withURL.canParse: valid absolute URLs still show their hostname, unparseable non-empty sources fall back to the raw string as the badge label, and the empty-source"unknown"fallback is unchanged.Added three render tests (bare domain, relative path, non-URL string) asserting the render doesn't throw and the fallback label appears; 29/29 pass in Chromium.