fix(elements): bound code block token cache with LRU eviction - #454
Open
ephraimduncan wants to merge 1 commit into
Open
fix(elements): bound code block token cache with LRU eviction#454ephraimduncan wants to merge 1 commit into
ephraimduncan wants to merge 1 commit into
Conversation
Streaming tool input/output re-highlights every intermediate version of a code string, and each unique string was cached forever in the module-scoped tokensCache, growing tab memory without limit during long conversations. Cap the cache at 100 entries: refresh recency on hit, evict the oldest insertion when full. The language highlighter cache stays unbounded since it is naturally limited by the set of loaded languages.
Contributor
|
@ephraimduncan is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tokensCacheinpackages/elements/src/code-block.tsxis module-scoped and never evicts. Streaming call sites (ToolInput/ToolOutputintool.tsx) render<CodeBlock>with a growing JSON string, and every intermediate version gets a unique cache key (the key includescode.length), so each streamed frame's fullThemedToken[][]was retained for the lifetime of the page. Long conversations grew tab memory without bound.Fix
tokensCacheat 100 entries (MAX_TOKENS_CACHE_SIZE).highlighterCacheis untouched — it's naturally bounded by the finite set of loaded languages.Verification
__tests__/code-block.test.tsx: fills 100 unique entries, refreshes one, overflows with 99 more, then asserts the refreshed entry is still served synchronously from cache while an unrefreshed entry returnsnull(evicted).tscclean for the changed file; ultracite reports 0 warnings/errors.